Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third_party-crashpad-crashpad-client-settings.cc.patch #8278

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

mariospr
Copy link
Contributor

This patch could be removed in favour of a chromium_src override
redefining the Settings::GetClientID() method into something that
uses the original implementation from upstream and simply resets
the memory of client_id before returning when needed.

Resolves brave/brave-browser#14789

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Based on description of brave/brave-browser#8865:

  1. go to brave://crash
  2. go to brave://crashes and ensure the crash has been sent
  3. lookup the crash id on backtrace
  4. guid should be 0 or not present

@mariospr mariospr added this to the 1.24.x - Nightly milestone Mar 17, 2021
@mariospr mariospr requested a review from mkarolin March 17, 2021 18:33
@mariospr mariospr requested a review from a team as a code owner March 17, 2021 18:33
@mariospr mariospr self-assigned this Mar 17, 2021
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

This patch could be removed in favour of a chromium_src override
redefining the Settings::GetClientID() method into something that
uses the original implementation from upstream and simply resets
the memory of client_id before returning when needed.

Resolves brave/brave-browser#14789
@mariospr
Copy link
Contributor Author

@bridiver Looks like GH requires your review to unblock merging this, PTAL thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove third_party-crashpad-crashpad-client-settings.cc.patch
3 participants