Crash reports contain guid and env

[bridiver]

Description

Crash reports contain a guid and env info

Steps to Reproduce

1. go to brave://crash
2. go to brave://crashes and ensure the crash has been sent
3. lookup the crash id on backtrace

Actual result:

unique guid is present
env vars are also stripped by backtrace so this can't be verified directly through the UI, but we are definitely sending them

Expected result:

guid should be 0 or not present

Reproduces how often:

always

Brave version (brave://version info)

• Can you reproduce this issue with the current release?
  yes
• Can you reproduce this issue with the beta channel?
  yes
• Can you reproduce this issue with the dev channel?
  yes
• Can you reproduce this issue with the nightly channel?
  yes

[bsclifton]

Looks like this was never tested @bridiver because the milestone is missing. This was merged into 1.8 - did you want to give things a look in Backtrace?

I'll go ahead and posthumously assign the 1.8 milestone to this and remove QA/Yes

[bsclifton]

Found this was not working as expected during troubleshooting session with @NejcZdovc

@bridiver suggested a patch which I just verified

[kjozwiak]

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.64 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.15.5 (Build 19F101)

Reproduced the original issue using 1.10.90 CR: 83.0.4103.97 by crashing via Brave using brave://crash and brave://gpucrashes. Checked BackTrace the above crashes were displaying the guid

• ensured that we're blanking out the guid now that the above fix has landed
• ensured that it's not appearing in BackTrace when looking up the Uploaded Crash Report ID

Examples:

Being sent via 1.10.90 CR: 83.0.4103.97

Not being sent via 1.10.90 CR: 83.0.4103.97

Verification passed on

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Windows 8.1 (Build 9600.19728)

Reproduced in 1.10.x

• ensured that guid not appearing in BackTrace when looking up the Uploaded Crash Report ID
  

---

Unable to check on Linux due to known issue #4296

Attempted using

Brave	1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

[kjozwiak]

@bsclifton @bridiver is there a way to see if the env is being sent? I couldn't see evn in the URL or the Summary under Charles Proxy when sending the into to https://cr.brave.com. Is the above good enough for a verification?

[bsclifton]

@kjozwiak yup- above looks perfect! 😄👌 I don't think env will show unless it's set. So this is great