Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce frequency of default browser dialog #8150

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Mar 5, 2021

Resolves brave/brave-browser#14502

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch browser with any profile (clean or existing both are fine)
  2. Repeat launch and check default browser dialog is launched 3rd and 20th launching
  3. Set as default
  4. Launch browser and check dialog is not launched anymore
  5. Set another browser as a default browser
  6. Repeat launch and check default browser dialog is launched 3rd and 20th launching

Note If active tab is welcome page, dialog is not visible even if it's 3rd or 20th launching.

@emerick emerick self-assigned this Mar 5, 2021
@emerick emerick force-pushed the reduce-frequencey-default-browser-dialog branch from 9266f0d to 519df41 Compare March 5, 2021 19:58
@emerick emerick requested a review from bbondy March 5, 2021 20:04
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 5, 2021
@emerick emerick force-pushed the reduce-frequencey-default-browser-dialog branch from 519df41 to 95f3ac3 Compare March 5, 2021 22:51
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong
Copy link
Member

@emerick curious why you run this only on iOS CI?

@emerick
Copy link
Contributor Author

emerick commented Mar 6, 2021

@simonhong The first CI run passed on all but iOS. Thanks for mentioning, forgot to mention it here.

@simonhong
Copy link
Member

@emerick Ah. ok!

@emerick
Copy link
Contributor Author

emerick commented Mar 6, 2021

iOS completed successfully, merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow-up to #12203 reduce dialog frequency to display twice
4 participants