follow-up to #12203 reduce dialog frequency to display twice

[rebron]

Description

Default browser dialog prompt frequency is 2nd, 3rd, 4th, 8th and 20th launches. This is too frequent and 2nd, 4th, and 8th dialog prompts should be removed.

Steps to Reproduce

See test plan:
brave/brave-core#7716

Expected result:

Only show prompt at 3rd and 20th browser open.

Reproduces how often:

Easily.

Brave version (brave://version info)

Brave | 1.21.73

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related: #12203

[LaurenWags]

Verified passed with

Brave	1.21.74 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	Linux

Verified test plan from brave/brave-core#8150.

Confirmed when Brave is not the default I am shown the default browser dialog on 3rd and 20th launches.
Confirmed when Brave is the default I am not shown the default browser dialog on the 3rd and 20th launches.
Confirmed when brave://welcome is the active tab I am not shown the default browser dialog on 3rd and 20th launches.

---

Verified PASSED using

Brave	1.21.74 Chromium: 89.0.4389.72 (Official Build) (x86_64)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	macOS Version 11.2.2 (Build 20D80)

Verified test plan from brave/brave-core#8150.

Confirmed when Brave is not the default, I am shown the default browser dialog on 3rd and 20th launches.
Confirmed when Brave is the default I am not shown the default browser dialog on the 3rd and 20th launches.
Confirmed when brave://welcome is the active tab I am not shown the default browser dialog on 3rd and 20th launches.

---

Verified PASSED on Win 10 x64` using the following build:

Brave | 1.21.74 Chromium: 89.0.4389.72 (Official Build) (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2009 (Build 19042.844)

Verified test plan from brave/brave-core#8150.

• Confirmed when Brave is not the default, I am shown the default browser dialog on 3rd and 20th launches.
• Confirmed when Brave is the default I am not shown the default browser dialog on the 3rd and 20th launches.
• Confirmed when brave://welcome is the active tab I am not shown the default browser dialog on 3rd and 20th launches.

[VAggrippino]

Just like with every other browser, the prompt should show every time the browser is opened until the user unchecks a box labeled "Always check if Brave is my default browser". The current functionality is the result of a conscious decision by the developers to irritate users. Who came up with this nonsense?