Applied Shields v2 UX to settings and shields panel and use FP V2 by default #5684
Conversation
simonhong
requested review from
bridiver,
pes10k,
bsclifton,
rebron and
antonok-edm
simonhong
force-pushed
the
use_v2_shields_ux
branch
from
7c57154
to
f1639aa
Compare
|
Labels and renaming looks great. Will leave the rest to @pes10k. |
|
This all looks great to me, terrific @simonhong ! |
|
@bridiver ping to owners review. |
| case ControlType::BLOCK: | ||
| return "block"; | ||
| case ControlType::BLOCK_THIRD_PARTY: | ||
| FALLTHROUGH; |
There was a problem hiding this comment.
doesn't this also need a v2 check?
There was a problem hiding this comment.
In the UI, same string default is only used for BLOCK_THIRD_PARTY and DEFAULT.
|
Yep, these are for v2 fingerprinting, but we're aiming to ship v2 in 1.11, so should all line up :) Right now the v2 fingerprinting protects haven't been fully implemented, but have eclipsed what was available in v1, so switching over to v2, even as is, is strictly superior |
v2 is used by default.
simonhong
force-pushed
the
use_v2_shields_ux
branch
from
f1639aa
to
0d2a1a2
Compare
simonhong
changed the title
| map->SetContentSettingCustomScope( | ||
| ContentSettingsPattern::Wildcard(), ContentSettingsPattern::Wildcard(), | ||
| ContentSettingsType::PLUGINS, brave_shields::kFingerprinting, | ||
| ContentSettingsType::PLUGINS, brave_shields::kFingerprintingV2, | ||
| CONTENT_SETTING_BLOCK); | ||
| map->SetContentSettingCustomScope( |
There was a problem hiding this comment.
this is not relevant anymore, there is no longer a first/third party scope. Can you please cleanup the tests in a followup?
There was a problem hiding this comment.
Delete brave_infura_project_id arg on mobile
Delete brave_infura_project_id arg on mobile
Resolves brave/brave-browser#9194
Resolves brave/brave-browser#9975
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.