Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out Doubleclick's tracking query string parameter #5633

Merged
merged 1 commit into from
May 25, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented May 22, 2020

Resolves brave/brave-browser#9879.

Submitter Checklist:

Test Plan:

Go to https://brave.com/?dclid=1 and confirm that the URL bar shows https://brave.com/ (no query string parameter).

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier added this to the 1.11.x - Nightly milestone May 22, 2020
@fmarier fmarier requested a review from iefremov May 22, 2020 21:56
@fmarier fmarier self-assigned this May 22, 2020
@fmarier
Copy link
Member Author

fmarier commented May 25, 2020

The unit test failure is unrelated, see https://bravesoftware.slack.com/archives/C7VLGSR55/p1590379647293400.

The npm audit failure is a known problem, also unrelated to this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out Doubleclick's tracking parameter from the query string
2 participants