Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out Doubleclick's tracking parameter from the query string #9879

Closed
fmarier opened this issue May 21, 2020 · 1 comment · Fixed by brave/brave-core#5633
Closed

Filter out Doubleclick's tracking parameter from the query string #9879

fmarier opened this issue May 21, 2020 · 1 comment · Fixed by brave/brave-core#5633

Comments

@fmarier
Copy link
Member

fmarier commented May 21, 2020

Test plan

See brave/brave-core#5633 (comment)

Description

Google Display Ads uses a dclid query string parameter to tie ad clicks to individual users and GTM will use it in the same way as gclid.

This enhanced attribution was designed to work around earlier versions of ITP.

Example (from https://va.tech.purdue.edu/webHistory/interactiveOrigin5-stackzero.php):

http://go.artinstitutes.edu/search/brand/local/PSGLC?source=BGNAG&ven=search&Tac=sem&school=chicago&Matchtype=Exact&Utm_source=Google&Utm_medium=cpc&ds_c=Brand_Natl_Geo_Exact&ds_ag=Brand_Chicago_Exact&ds_k=art+institute+of+chicago&ds_eid=700000001042009&gclid=CjwKEAjwq6m3BRCP7IfMq6Oo9gESJACRc0bN3J-fcQ1t1DO5AyuTfKIyFbgTFPfCmM2PmPXyGdrKRBoCmv3w_wcB&gclsrc=aw.ds&dclid=CNW5-P6UycsCFRYdaQodgbMCTA
@LaurenWags
Copy link
Member

LaurenWags commented Jun 18, 2020

Verified passed with

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-06-18 at 12 10 37 PM

  • Confirmed parameter is filtered out on 1.11.x:

Screen Shot 2020-06-18 at 12 11 16 PM

Verification passed on

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Windows 10 OS Version 1903 (Build 18362.30)

Reproduced in 1.10.x

image

1.11.x
image


Verified passed with

Brave	1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment