Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase image sizes for favicons on rewards panel/site #5244

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 14, 2020

Resolves brave/brave-browser#1597

Submitter Checklist:

Test Plan:

  • enable rewards
  • visit couple of pages and make sure that image is displayed in the panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added feature/rewards CI/skip Do not run CI builds (except noplatform) labels Apr 14, 2020
@NejcZdovc NejcZdovc added this to the 1.9.x - Nightly milestone Apr 14, 2020
@NejcZdovc NejcZdovc requested a review from a team April 14, 2020 06:57
@NejcZdovc NejcZdovc self-assigned this Apr 14, 2020
@NejcZdovc NejcZdovc merged commit 75ff144 into master Apr 22, 2020
@NejcZdovc NejcZdovc deleted the site-icon branch April 22, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicons are low resolution on rewards panel and contribution table
2 participants