Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicons are low resolution on rewards panel and contribution table #1597

Closed
srirambv opened this issue Oct 15, 2018 · 8 comments · Fixed by brave/brave-core#5244
Closed
Assignees
Labels
feature/rewards OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Rewards panel shows favicons which are pixelated needs to have a high resolution icons

Steps to Reproduce

  1. Enable Rewards
  2. Add funds
  3. Visit any site and click the rewards button, see pixelated icons and close it immediately

Actual result:

image

Expected result:

Should show proper icons

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes
  • Does it reproduce on browser-laptop?
    No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. misc/icons labels Oct 15, 2018
@srirambv srirambv added this to the 0.57.x milestone Oct 15, 2018
@srirambv
Copy link
Contributor Author

Even contribution table has low resolution icons
image

@srirambv srirambv changed the title Low resolution favicons on rewards panel Low resolution favicons on rewards panel and contribution table Oct 16, 2018
@NejcZdovc
Copy link
Contributor

we get this icons from favicon store (chromium has control over it), will try to bump size that we are requesting

@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 16, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@srirambv
Copy link
Contributor Author

@NejcZdovc we might need to bump this one. Looks awfully bad for some sites which has small icons in site favicon
Pasted_image_at_2019-03-19__10_53_AM

@jonathansampson
Copy link
Contributor

jonathansampson commented Jan 30, 2020

This issue impacts our New Tab Page too. For example, consider this icon: brave://favicon/size/64@1x/http://try.bravesoftware.com/v1/

image

@NejcZdovc
Copy link
Contributor

agree, let's go with 64@1x

@jonathansampson
Copy link
Contributor

@NejcZdovc Does 64@1x look good on a high-density display? Or would 128 be more preferable?

@NejcZdovc
Copy link
Contributor

I would go with 64 for now and we can always update if needed

@NejcZdovc
Copy link
Contributor

Note that if site provides favicon only in resolution 32x32 like pia we can't do anything really about it. It's on sites to provide good resolution

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 14, 2020
@NejcZdovc NejcZdovc added this to the 1.9.x - Nightly milestone Apr 14, 2020
@NejcZdovc NejcZdovc self-assigned this Apr 14, 2020
@NejcZdovc NejcZdovc added QA/No and removed QA/Yes labels Apr 14, 2020
@NejcZdovc NejcZdovc removed this from the 1.9.x - Beta milestone Apr 22, 2020
@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone Apr 22, 2020
@rebron rebron changed the title Low resolution favicons on rewards panel and contribution table Favicons are low resolution on rewards panel and contribution table Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants