Update search engine defaults for DE / AU / NZ / IE #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
force-pushed
the
bsc-search-engine-default
branch
from
0112e12
to
8decce1
Compare
bsclifton
force-pushed
the
bsc-search-engine-default
branch
from
8decce1
to
60e3672
Compare
iefremov
reviewed
Oct 3, 2019
chromium_src/components/search_engines/brave_template_url_service_util_unittest.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Oct 3, 2019
chromium_src/components/search_engines/brave_template_url_prepopulate_data_unittest.cc
Show resolved
Hide resolved
iefremov
reviewed
Oct 3, 2019
chromium_src/components/search_engines/brave_template_url_service_util_unittest.cc
Outdated
Show resolved
Hide resolved
mkarolin
reviewed
Oct 3, 2019
chromium_src/components/search_engines/template_url_prepopulate_data.cc
Outdated
Show resolved
Hide resolved
bsclifton
force-pushed
the
bsc-search-engine-default
branch
from
e09482b
to
819a68b
Compare
|
Looks like just a lint failure - I can fix this real quick: |
bsclifton
force-pushed
the
bsc-search-engine-default
branch
from
819a68b
to
9be289f
Compare
mkarolin
reviewed
Oct 4, 2019
chromium_src/components/search_engines/brave_template_url_prepopulate_data_unittest.cc
Outdated
Show resolved
Hide resolved
mkarolin
reviewed
Oct 4, 2019
chromium_src/components/search_engines/brave_template_url_service_util_unittest.cc
Outdated
Show resolved
Hide resolved
mkarolin
reviewed
Oct 4, 2019
chromium_src/components/search_engines/brave_template_url_service_util_unittest.cc
Outdated
Show resolved
Hide resolved
mkarolin
reviewed
Oct 4, 2019
chromium_src/components/search_engines/template_url_prepopulate_data.cc
Outdated
Show resolved
Hide resolved
|
Has one failing lint (swear I fixed all in a previous commit), but otherwise looks good. I'll push a quick fix for the lint and then merge (as this is approved and CI has otherwise passed) |
bsclifton
added a commit
that referenced
this pull request
Oct 8, 2019
Update search engine defaults for DE / AU / NZ / IE
4 tasks
bsclifton
added a commit
that referenced
this pull request
Oct 8, 2019
Update search engine defaults for DE / AU / NZ / IE
4 tasks
32 tasks
bsclifton
added a commit
that referenced
this pull request
Oct 11, 2019
Fixes brave/brave-browser#6421 Problem was regular DDG not found in the entries returned (since locale specific was returned instead). Besides adding other entries, this also puts a dcheck in place to ensure an engine gets set (otherwise, the error thrown is no immediately clear and a bit hard to trace). (bug unintentionally introduced with #3591)
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6187
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See https://github.com/brave/internal/issues/647
Reviewer Checklist:
After-merge Checklist:
changes has landed on.