Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search engine defaults for DE / AU / NZ / IE #6187

Closed
bsclifton opened this issue Sep 26, 2019 · 1 comment · Fixed by brave/brave-core#3591
Closed

Update search engine defaults for DE / AU / NZ / IE #6187

bsclifton opened this issue Sep 26, 2019 · 1 comment · Fixed by brave/brave-core#3591

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 26, 2019

Description

Update search engine defaults for Germany (DE), Australia (AU), New Zealand (NZ), and IE (Ireland)

Test plan

See brave/internal#647

@btlechowski
Copy link

btlechowski commented Oct 12, 2019

Verification passed on

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/647

New Users US
Verified the search string
image

New Users PL
Verified the search string
image

New Users De
Verified the search string
Verified duckduckgo set as default search engine
image

New Users AU
Verified the search string
Verified duckduckgo set as default search engine
image

Upgraded Users De
Default search engine qwant was replaced by duckduckgo. Expected per https://github.com/brave/internal/issues/647#issuecomment-540854051
Search string is replaced for duckduckgo. Logged #6424

Upgraded Users De, custom default search engine (google)
Verified google remained default search engine
Search string is replaced for duckduckgo. Logged #6424
image

Upgraded Users De, custom default search engine (qwant)
Verified qwant remained default search engine
Search string is replaced for duckduckgo. Logged #6424
image

Upgraded Users AU
Default search engine google was replaced by duckduckgo. Expected per https://github.com/brave/internal/issues/647#issuecomment-540854051
Search string is replaced for duckduckgo. Logged #6424
image

Upgraded Users AU, custom default search engine (google)
Verified google remained default search engine
Search string is replaced for duckduckgo. Logged #6424
image

Upgraded Users AU, custom default search engine (duckduckgo)
Verified duckduckgo remained default search engine
Another instance of DuckDuckGo is added to search engines. Logged #6453
image

I was unable to test NZ and IE, because Ubuntu 18.04 does not support them. Setting regional formats does not work.
image

Verification is passed on

Brave 0.70.113 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan from Verified test plan from brave/internal#647

a. Users in the US,UK and INDIA locale:

  • Verified the search string https://duckduckgo.com/?q=%s&t=brave and Google is the default search engine
    image
  • Verified new installs use Google as default
  • Verified upgrades where the default was Google in 0.69.x retains Google on upgrade.
  • Verified upgrades where the default was user changed to DDG in 0.69.x retains DDG on upgrade.
  • Verified upgrades where the default was user changed to something else (not Google or DDG) in 0.69.x was retained on upgrade.
  • Verified for New Private, Guest, and Tor windows.
  • for the UK, INDIA, and Germanylocale only, encountered Incognito still being generated from translated strings #2147

b. New Users in the De/German locale:

Verified the search string https://duckduckgo.com/?q=%s&t=bravened and DDG is the default search engine
image

c. Upgraded Users in the De/German locale:

d. New user in the AU/Australia locale:

Verified the search string https://duckduckgo.com/?q=%s&t=braveed and DDG is the default search engine
image

e. Upgraded Users in the AU/Australia locale:

  • Default search engine google is replaced by duckduckgo, after upgrade the search string displayed as https://duckduckgo.com/?q=%s&t=braveed

image

f. New user in the NZ/New Zealand locale:

Verified the search string https://duckduckgo.com/?q=%s&t=braveed and DDG is the default search engine
image

g. Upgraded Users in the NZ/New Zealand locale:

  • Default search engine google is replaced by duckduckgo, after upgrade the search string displayed as https://duckduckgo.com/?q=%s&t=braveed

image

h. New user in the IE/Ireland locale:

image

i. Upgraded Users in the IE/Ireland locale:
Default search engine google is replaced by duckduckgo, after upgrade the search string displayed as https://duckduckgo.com/?q=%s&t=braveed

image

Verified passed with

Brave 0.70.115 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

For US and UK locales:

  • Verified new installs use Google as default
  • Verified upgrades where the default was Google in 0.69.x retains Google on upgrade.
  • Verified upgrades where the default was user changed to DDG in 0.69.x retains DDG on upgrade.
  • Verified upgrades where the default was user changed to something else (not Google or DDG) in 0.69.x was retained on upgrade.
  • Verified for New, Private, Guest, and Tor windows. See note below about Tor windows.
  • for UK locale only, encountered Incognito still being generated from translated strings #2147

For Germany (DE) locale:

DE-new_install

For Australia (AU) locale:

AU-new_install

For New Zealand (NZ) locale:

NZ-new_install

For Ireland (IE) locale:

IE-new_install

Notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment