Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Brave ads for Australia, New Zealand and Ireland #2865

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Enable Brave ads for Australia, New Zealand and Ireland #2865

merged 1 commit into from
Jul 15, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 4, 2019 •
edited
Loading

Fixes brave/brave-browser#5153
Requires #2928

Submitter Checklist:

Test Plan:

  • Confirm Brave ads work as expected in the United States of America, Canada, United Kingdom, Germany, France, Australia, New Zealand and Ireland
  • Confirm Brave ads are not supported in all other regions
  • Confirm Ads switch and "Brave Ads have arrived!" on-boarding notification are working as expected for upgrade paths from 0.62.x where Rewards is disabled
  • Confirm Ads switch and "Brave Ads have arrived!" on-boarding notification are working as expected for upgrade paths from 0.62.x where Rewards is enabled
  • Confirm Ads switch and "Brave Ads have arrived!" on-boarding notification are working as expected for upgrade paths from the previous version where Rewards and Ads are both disabled
  • Confirm Ads switch and "Brave Ads have arrived!" on-boarding notification are working as expected for upgrade paths from the previous version where Rewards and Ads are both enabled
  • Confirm Ads switch and "Brave Ads have arrived!" on-boarding notification are working as expected for upgrade paths from the previous version where Rewards is enabled and Ads is disabled

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 0.69.x - Nightly milestone Jul 4, 2019
@tmancey tmancey self-assigned this Jul 4, 2019
emerick
emerick previously approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does it require any test updates?

@tmancey tmancey changed the title Enable Brave ads for Australia, New Zealand and Ireland [WIP] Enable Brave ads for Australia, New Zealand and Ireland Jul 4, 2019
@tmancey tmancey requested a review from emerick July 4, 2019 11:53
@tmancey tmancey force-pushed the issues/5153 branch 3 times, most recently from b1fea9d to 7db2483 Compare July 5, 2019 15:00
@tmancey tmancey changed the title [WIP] Enable Brave ads for Australia, New Zealand and Ireland Enable Brave ads for Australia, New Zealand and Ireland Jul 8, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Jul 8, 2019

LGTM, does it require any test updates?

Tests are covered under english user models

@tmancey tmancey force-pushed the issues/5153 branch 4 times, most recently from 49d30c8 to 86a4b6b Compare July 10, 2019 15:44
@tmancey tmancey requested a review from bsclifton as a code owner July 10, 2019 15:44
@tmancey tmancey force-pushed the issues/5153 branch 8 times, most recently from 72cf61b to 0bea9a4 Compare July 11, 2019 10:04
@tmancey tmancey force-pushed the issues/5153 branch 2 times, most recently from 232e7af to e23eb4e Compare July 11, 2019 10:30
NejcZdovc
NejcZdovc reviewed Jul 15, 2019
View reviewed changes
components/brave_ads/browser/ads_service_impl.cc

auto* rewards_service =
brave_rewards::RewardsServiceFactory::GetForProfile(profile_);
auto* rewards_notification_service =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check if rewards_service is null

NejcZdovc
NejcZdovc reviewed Jul 15, 2019
View reviewed changes
components/brave_ads/browser/ads_service_impl.cc
brave_rewards::RewardsServiceFactory::GetForProfile(profile_);
auto* rewards_notification_service =
rewards_service->GetNotificationService();
rewards_notification_service->DeleteNotification(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check if rewards_notification_service is null

@tmancey tmancey requested a review from NejcZdovc July 15, 2019 18:33
NejcZdovc
NejcZdovc approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good to me, CI is also passing

@tmancey tmancey merged commit d09f054 into master Jul 15, 2019
@tmancey tmancey deleted the issues/5153 branch July 15, 2019 20:15
This was referenced Jul 16, 2019
Merged
Merged
@LaurenWags LaurenWags mentioned this pull request Jul 26, 2019
Closed
@tmancey tmancey mentioned this pull request Jul 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@emerick emerick Awaiting requested review from emerick

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.

Enable Brave ads for Australia, New Zealand and Ireland
4 participants
@tmancey @bsclifton @emerick @NejcZdovc