Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Brave ads for Australia, New Zealand and Ireland #5153

Closed
tmancey opened this issue Jul 4, 2019 · 13 comments · Fixed by brave/brave-core#2865
Closed

Enable Brave ads for Australia, New Zealand and Ireland #5153

tmancey opened this issue Jul 4, 2019 · 13 comments · Fixed by brave/brave-core#2865
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.67.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 4, 2019 •
edited
Loading

In preparation of testing out Brave ads in Australia, New Zealand, and Ireland, we need to enable users in those regions to turn on ads, and provide them a notification of the availability
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. feature/ads labels Jul 4, 2019
@tmancey tmancey added this to the 0.69.x - Nightly milestone Jul 4, 2019
@tmancey tmancey self-assigned this Jul 4, 2019
@tmancey tmancey changed the title Enable Ads in Australia, New Zealand, and Ireland Enable Ads in Australia, New Zealand and Ireland Jul 4, 2019
@tmancey tmancey changed the title Enable Ads in Australia, New Zealand and Ireland Enable Brave ads for Australia, New Zealand and Ireland Jul 4, 2019
@tmancey tmancey mentioned this issue Jul 4, 2019
Merged
32 tasks
@ryanbr
Copy link

ryanbr commented Jul 6, 2019

I approve :)

@dynamicdolphin
Copy link

Eagerly awaiting this...
Still saying "Sorry! Ads are not yet available in your region."

@tmancey
Copy link
Contributor Author

tmancey commented Jul 15, 2019

Eagerly awaiting this...
Still saying "Sorry! Ads are not yet available in your region."

Merged with master and will be in the next nightly build, any feedback would be much appreciated

@tmancey
Copy link
Contributor Author

tmancey commented Jul 15, 2019

I approve :)

Merged with master and will be in the next nightly build, any feedback would be much appreciated

@tmancey tmancey mentioned this issue Jul 15, 2019
Closed
@dynamicdolphin
Copy link

When can we expect Ads to be available for Australia?
Still not showing, I'm running Version 0.66.99

@tmancey
Copy link
Contributor Author

tmancey commented Jul 16, 2019

When can we expect Ads to be available for Australia?
Still not showing, I'm running Version 0.66.99

Currently this change has only be merged with Nightly, if you install our nightly build you will be able to use Ads.

@dynamicdolphin
Copy link

Still saying No Ads Available in Nightly 0.69.44..?

@tmancey
Copy link
Contributor Author

tmancey commented Jul 16, 2019

Still saying No Ads Available in Nightly 0.69.44..?

Apologies I should have mention this was added to 0.69.66, so once 0.69.66 or above is available the feature will be enabled, thanks

This was referenced Jul 16, 2019
Merged
Merged
Merged
tmancey added a commit to brave/brave-core that referenced this issue Jul 22, 2019
@tmancey
Enable Brave ads for Australia, New Zealand and Ireland
25e7d76 
Fixes brave/brave-browser#5153
tmancey added a commit to brave/brave-core that referenced this issue Jul 22, 2019
@tmancey
Enable Brave ads for Australia, New Zealand and Ireland
09bac5f 
Fixes brave/brave-browser#5153
@LaurenWags
Copy link
Member

LaurenWags commented Jul 26, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X
  1. Clean install of 0.67.117 (configured appropriately). Enabled Rewards, verified Ads were enabled, no “Sorry” message on Ads panel. Verified I was served an ad as expected. Ads panel info incremented as expected. PASS for AUS, NZ, IRL
  2. Installed 0.66.101 (configured appropriately). Enabled Rewards. Upgraded on test channel to 0.67.117. Verified I was notified about Ads via BAT logo notification. Verified I was able to turn on Ads and was served an ad as expected. Ads panel info incremented as expected. PASS for AUS, NZ, IRL
  3. Installed 0.66.101 (configured appropriately). Enabled Rewards. Upgraded on test channel to 0.67.117. Verified I was notified about Ads via BAT logo notification. I did not enable Ads and browsed around a bit to verify I was not served any ads. PASS for AUS, NZ, IRL
  4. Installed 0.66.101 (configured appropriately). Did not enable Rewards but did click on BAT logo to make red notification bubble go away. Upgraded on test channel to 0.67.117. Saw red notification dot on BAT logo. Inquired about it, but it seems to be expected for now. Note - notification bubble did go away after a bit. Saw same results for all 3 regions: AUS, NZ, IRL
  5. Installed 0.62.51 (configured appropriately). Enabled Rewards. Upgraded on test channel to 0.67.117. Verified I was notified about Ads via BAT logo notification. PASS for AUS, NZ, IRL
  6. Installed 0.62.51 (configured appropriately). Did not enable Rewards but did click on BAT logo to make red notification bubble go away. Upgraded on test channel to 0.67.117. Saw red notification dot on BAT logo. Inquired about it, but it seems to be expected for now. Note - notification bubble did go away after a bit. Saw same results for all 3 regions: AUS, NZ, IRL

Verification passed on

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2865
On Ubuntu 18.04 LTS New Zealand behavior is different than expected, because the locale is set to en_GB instead of en_NZ. This means that even on 0.66.101 users will get ads. After update to 0.67.117 the ads are still shown.
Experienced notification bubble issue described by @LaurenWags when updating from 0.62.51 for all languages.

Verification passed on

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

@kjozwiak kjozwiak mentioned this issue Jul 26, 2019
Closed
82 tasks
@Flash-ZA
Copy link

Please South Africa next 😫 Been hyped for this for way too long now

This was referenced Jul 29, 2019
Closed
Closed
@C-J-1
Copy link

C-J-1 commented Aug 5, 2019 •
edited
Loading

I am totally keen for Australian Ads. What an awesome browser so far.

@tmancey
Copy link
Contributor Author

tmancey commented Aug 5, 2019

I am totally keen for Australian Ads. What an awesome browser so far.

Australian Ads are now in the release channel, please update to the latest version.

@tmancey
Copy link
Contributor Author

tmancey commented Aug 5, 2019

Please South Africa next 😫 Been hyped for this for way too long now

We are working to add more countries, keep an eye on Reddit, GitHub etc. for latest updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Enable Brave ads for Australia, New Zealand and Ireland brave/brave-core
8 participants
@tmancey @ryanbr @Flash-ZA @C-J-1 @LaurenWags @btlechowski @GeetaSarvadnya @dynamicdolphin