Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes panel db query #1589

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Fixes panel db query #1589

merged 1 commit into from
Feb 6, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 6, 2019 •
edited by jasonrsadler
Loading

Resolves brave/brave-browser#3244

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • visit some youtube publisher video
  • make sure that publisher is recorded in ac table
  • close browser
  • open publisher db and modify reconcile stamp to something in the past
  • open browser again and visit the same publisher
  • make sure that correct publisher is displayed in the panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.62.x - Nightly milestone Feb 6, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 6, 2019
@NejcZdovc NejcZdovc force-pushed the media-publisher-db branch 3 times, most recently from 480397b to d698c42 Compare February 6, 2019 07:56
ryanml
ryanml reviewed Feb 6, 2019
View reviewed changes
components/brave_rewards/browser/publisher_info_database.cc

info_sql.BindString(0, filter.id);
info_sql.BindInt64(1, filter.reconcile_stamp);
info_sql.BindString(2, filter.id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like has already been bound, is this unneeded?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The args need to be bound, not the id. arg[2] hasn't been bound yet here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup we need it as we have three ? in the query and we use id in two places

@NejcZdovc NejcZdovc merged commit 7b16f3c into master Feb 6, 2019
@NejcZdovc NejcZdovc deleted the media-publisher-db branch February 6, 2019 16:47
NejcZdovc added a commit that referenced this pull request Feb 6, 2019
@NejcZdovc
Merge pull request #1589 from brave/media-publisher-db
5bba501 
Fixes panel db query
@NejcZdovc NejcZdovc mentioned this pull request Feb 6, 2019
Merged
NejcZdovc added a commit that referenced this pull request Feb 12, 2019
@NejcZdovc
Fixes panel query for the publisher
2b50d59 
Related #1589
@NejcZdovc NejcZdovc mentioned this pull request Feb 12, 2019
Merged
18 tasks
This was referenced Feb 25, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml ryanml left review comments

@jasonrsadler jasonrsadler jasonrsadler approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.62.x - Release
Development

Successfully merging this pull request may close these issues.

youtube publisher is shown for media publisher
3 participants
@NejcZdovc @ryanml @jasonrsadler