-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect attention % values in ac table after visiting excluded site #3341
Comments
Verified this issue does not reproduce on latest Dev
|
@kjozwiak should we create custom fix for 0.60 or are we ok with just closing it as it will be fixed in 0.61? |
Closing this issue. Fixed in 61.x with: brave/brave-core#1600 |
@brave/legacy_qa when verifying this issue we will need to see what happens if you encounter this issue on 0.60.x and then update to a build (in 0.61.x) with the fix. @NejcZdovc if someone is already in this state, will the fix for this issue update anyone in this state? |
Verification passed on
Verification passed on
Verification PASSED on
|
Description
If you exclude a site from your ac table and then visit it later, your attention percentage values in the table won't add up to 100%. It seems as though your table is counting the excluded site in your % values even though it's not listed in the table itself.
Steps to Reproduce
Found with an upgrade profile, but happens on a clean profile as well. Steps below are for clean profile.
Actual result:
Expected result:
All attention values should add up to 100%. Visiting the excluded site should not have any effect on the attention values since it is excluded.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release: does not reproduce on 0.59.35
Website problems only:
Additional Information
cc @brave/legacy_qa @NejcZdovc
The text was updated successfully, but these errors were encountered: