Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uplift to 1.45.x) remove set default search engine screen for BR / AR (#15669) #15677

Merged
merged 1 commit into from
Nov 4, 2022
Merged

(uplift to 1.45.x) remove set default search engine screen for BR / AR (#15669) #15677

merged 1 commit into from
Nov 4, 2022

Conversation

spylogsster
Copy link
Contributor

Uplift of #15669
Resolves brave/brave-browser#26182
Resolves brave/brave-browser#26181

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster
remove set default search engine screen for BR / AR (#15669)
542f9b2 
remove default search engine screen

(cherry picked from commit c63c27a)
@spylogsster spylogsster requested a review from a team as a code owner October 26, 2022 18:45
@spylogsster spylogsster self-assigned this Oct 26, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 26, 2022
@spylogsster spylogsster changed the title remove set default search engine screen for BR / AR (#15669) (uplift to 1.45.x) remove set default search engine screen for BR / AR (#15669) Oct 26, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.45.x - Release #6 milestone Nov 4, 2022
kjozwiak
kjozwiak approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per #15669 (comment) & #15669 (comment).

@kjozwiak kjozwiak merged commit f67c6f6 into 1.45.x Nov 4, 2022
@kjozwiak kjozwiak deleted the 15669_uplift_to_1.45.x branch November 4, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.45.x - Release #7
Development

Successfully merging this pull request may close these issues.
3 participants
@spylogsster @brave-builds @kjozwiak