Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search engine defaults for BR / AR #26181

Closed
rebron opened this issue Oct 21, 2022 · 11 comments · Fixed by brave/brave-core#15669
Closed

Update search engine defaults for BR / AR #26181

rebron opened this issue Oct 21, 2022 · 11 comments · Fixed by brave/brave-core#15669

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 21, 2022

Description

Update search engine defaults for:

  • Brazil (BR)
  • Argentina (AR)

Brave should be at the top of drop down list at brave://settings/search

Related: #18331 and #23814

Test plan

Region set to BR / AR

  1. Fresh profile
  2. Search onboarding should NOT be shown
  3. Default search engine SHOULD be Brave
  4. Visit brave://settings/searchEngines
  5. Brave SHOULD be first in the Default search engines list

Region set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX)

  1. Fresh profile
  2. Search onboarding SHOULD be shown
  3. Default will NOT be Brave Search
  4. Visit brave://settings/searchEngines
  5. Brave SHOULD be first in the Default search engines list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.

Notes for test plan

#23814 (comment)

@rebron rebron added OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality Brave Search labels Oct 21, 2022
@simonhong
Copy link
Member

Maybe we also want NTP search promotion to these new regions
https://github.com/brave/brave-variations/blob/main/seed/seed.json#L1185

@anthonypkeane
Copy link

We probably need to re-open this for Android as I'm not sure if the work is done yet.
cc @timchilds & @deeppandya

@simonhong simonhong assigned spylogsster and unassigned simonhong Oct 27, 2022
@deeppandya
Copy link

@anthonypkeane setting brave as default should be good but we need to change the onboarding behaviour for android.

@anthonypkeane
Copy link

This issue was closed incorrectly as the work on Android was not completed.

Reopening, adding the correct Android project and assigning to @deeppandya & @timchilds

@srirambv
Copy link
Contributor

srirambv commented Nov 4, 2022

@anthonypkeane the issue has an associated PR so it should not be reopened. If we need we can add an Android specific issue and mark this one as Desktop only

@brave-builds brave-builds added this to the 1.45.x - Release #6 milestone Nov 4, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

The above requires 1.45.121 or higher for 1.45.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

This issue was closed incorrectly as the work on Android was not completed.

Reopening, adding the correct Android project and assigning to @deeppandya & @timchilds

This particular PR can be verified on Android as well but the onboarding portion will be done via #26318 as per #26318 (comment). @brave/qa-team when verifying the above, you can use the STR/Cases outlined via brave/brave-core#15669 (comment) & brave/brave-core#15669 (comment). However, rather than going through all the cases I did, each platform should:

  • pick either BR or AR (the new ones added)
  • pick one of the previous locales that have Brave as default (CA / DE / FR / GB / US / AT / ES / MX)
  • pick a locale that doesn't have Brave as the default SE (example: Japan or Poland)
  • pick a locale that has Yandex set as the default SE

@kjozwiak kjozwiak closed this as completed Nov 7, 2022
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 7, 2022
@stephendonner
Copy link

stephendonner commented Nov 7, 2022

Verification PASSED using

Brave 1.45.121 Chromium: 107.0.5304.91 (Official version) (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Compiled 20G918)

BR (Brazilian) locale (new addition)

Case #1 - #26182

brave://welcome

Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
Captura de Tela 2022-11-07 às 5 24 55 PM Captura de Tela 2022-11-07 às 5 24 58 PM Captura de Tela 2022-11-07 às 5 25 01 PM

Case #2 - #26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
Captura de Tela 2022-11-07 às 5 25 17 PM Captura de Tela 2022-11-07 às 5 25 25 PM Captura de Tela 2022-11-07 às 5 25 35 PM
Updated Profile (Google/Brave)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Google is still the default SE for Normal Windows
    • ensured that Google wasn't replaced by Brave for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.45.118 1.45.121
Captura de Tela 2022-11-07 às 5 30 43 PM Captura de Tela 2022-11-07 às 5 33 10 PM
Example (Brave at top of list) Example (Brave at top of list)
Captura de Tela 2022-11-07 às 5 30 52 PM Captura de Tela 2022-11-07 às 5 33 20 PM
Updated Profile (DDG/Startpage)
  • installed 1.45.118
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
Captura de Tela 2022-11-07 às 5 37 22 PM Captura de Tela 2022-11-07 às 5 40 55 PM
Example (Brave at top of list) Example (Brave at top of list)
Captura de Tela 2022-11-07 às 5 37 45 PM Captura de Tela 2022-11-07 às 5 41 09 PM
Updated Profile (Qwant/Bing)
  • installed 1.45.118
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
Captura de Tela 2022-11-07 às 5 45 44 PM Captura de Tela 2022-11-07 às 5 48 03 PM
Example (Brave at top of list) Example (Brave at top of list)
Captura de Tela 2022-11-07 às 5 45 53 PM Captura de Tela 2022-11-07 às 5 48 12 PM

DE (German) locale (existing locale with Brave Search as default)

Case #1 - #26182

brave://welcome

Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
Bildschirmfoto 2022-11-07 um 5 55 15 PM Bildschirmfoto 2022-11-07 um 5 55 19 PM Bildschirmfoto 2022-11-07 um 5 55 22 PM

Case #2 - #26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
Bildschirmfoto 2022-11-07 um 5 58 19 PM Bildschirmfoto 2022-11-07 um 5 58 34 PM Bildschirmfoto 2022-11-07 um 5 58 49 PM
Updated Profile (Brave/Brave)
  • installed 1.45.118
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Brave is still the default SE for Normal & PB windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.45.118 1.45.121
Bildschirmfoto 2022-11-07 um 6 01 55 PM Bildschirmfoto 2022-11-07 um 6 05 15 PM
Example (Brave at top of list) Example (Brave at top of list)
Bildschirmfoto 2022-11-07 um 6 02 05 PM Bildschirmfoto 2022-11-07 um 6 05 25 PM
Updated Profile (DDG/Startpage)
  • installed 1.45.118
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
Bildschirmfoto 2022-11-07 um 6 08 28 PM Bildschirmfoto 2022-11-07 um 6 10 47 PM
Example (Brave at top of list) Example (Brave at top of list)
Bildschirmfoto 2022-11-07 um 6 08 38 PM Bildschirmfoto 2022-11-07 um 6 11 00 PM

JP (Japan) locale (doesn't have Brave Search as default)

Case #1 - #26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

Example Example Example Example
スクリーンショット 2022-11-07 18 50 03 スクリーンショット 2022-11-07 18 50 07 スクリーンショット 2022-11-07 18 50 09 スクリーンショット 2022-11-07 18 50 13

Case #2 - #26181

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
スクリーンショット 2022-11-07 18 51 38 スクリーンショット 2022-11-07 18 51 48 スクリーンショット 2022-11-07 18 52 05
Updated Profile (Google/Brave)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.45.118 1.45.121
スクリーンショット 2022-11-07 18 57 03 スクリーンショット 2022-11-07 18 58 37
Example (Brave at top of list) Example (Brave at top of list)
スクリーンショット 2022-11-07 18 57 15 スクリーンショット 2022-11-07 18 58 44
Updated Profile (Startpage/Bing)
  • installed 1.45.118
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
スクリーンショット 2022-11-07 19 10 10 スクリーンショット 2022-11-07 19 07 00
Example (Brave at top of list) Example (Brave at top of list)
スクリーンショット 2022-11-07 19 10 42 スクリーンショット 2022-11-07 19 07 27

RU (Russia) locale (Yandex as the default SE)

Case #1 - #26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

Example Example Example Example
Снимок экрана 2022-11-07 в 19 17 54 Снимок экрана 2022-11-07 в 19 17 58 Снимок экрана 2022-11-07 в 19 18 01 Снимок экрана 2022-11-07 в 19 18 13

Case #2 - #26181

Clean Profile
  • ensured that Yandex was selected as the default for Normal windows via brave://settings/searchEngines
  • ensured that Brave was selected as the default for Private windows via brave://settings/searchEngines
Example Example Example
Снимок экрана 2022-11-07 в 19 41 57 Снимок экрана 2022-11-07 в 19 42 08 Снимок экрана 2022-11-07 в 19 42 17
Updated Profile (Yandex/Brave)
  • installed 1.45.118
  • ensured that Yandex was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.46.96 and ensured that Yandex is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
1.45.118 1.45.121
Снимок экрана 2022-11-07 в 19 15 54 Снимок экрана 2022-11-07 в 19 18 30
Example Example
Снимок экрана 2022-11-07 в 19 16 07 Снимок экрана 2022-11-07 в 19 18 39
Updated Profile (Google/DDG)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
1.45.118 1.45.121
Снимок экрана 2022-11-07 в 19 53 47 Снимок экрана 2022-11-07 в 19 56 04
Example Example
Снимок экрана 2022-11-07 в 19 54 18 Снимок экрана 2022-11-07 в 19 56 13

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 8, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 8, 2022

Verification PASSED on

Brave | 1.45.121 Chromium: 107.0.5304.91 (Official Build) (64-bit)
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 10 Version 21H2 (Build 19044.2130)

AR (Argentina) locale (new addition)

Case #1 - #26182

brave://welcome

Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
image image image

Case #2 - #26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Google/Brave)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Google is still the default SE for Normal Windows
    • ensured that Google wasn't replaced by Brave for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (DDG/Startpage)
  • installed 1.45.118
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Qwant/Bing)
  • installed 1.45.118
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

FR (France) locale (existing locale with Brave Search as default)

Case #1 - #26182

brave://welcome

Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
image image image

Case #2 - #26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Brave/Brave)
  • installed 1.45.118
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 Chromium: 107.0.5304.91 and ensured that Brave is still the default SE for Normal & PB windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.45.118 1.45.121
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (DDG/Startpage)
  • installed 1.45.118
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

IN (India) locale (doesn't have Brave Search as default)

Case #1 - #26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

Example Example Example Example
image image image image

Case #2 - #26181

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Google/Brave)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.45.118 1.45.121
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Startpage/Bing)
  • installed 1.45.118
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.45.118 1.45.121
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

RU (Russia) locale (Yandex as the default SE)

Case #1 - #26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

Example Example Example Example
image image image image

Case #2 - #26181

Clean Profile
  • ensured that Yandex was selected as the default in Normal windows via brave://settings/searchEngines
  • ensured that Brave was selected as the default in Private windows via brave://settings/searchEngines
  • ensured that Yandex was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Yandex was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Yandex/Brave)
  • installed 1.45.118
  • ensured that Yandex was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Yandex is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
1.45.118 1.45.121
image image
Example Example
image image
Updated Profile (Google/DDG)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
1.45.118 1.45.121
image image
Example Example
image image

@btlechowski
Copy link

Verification passed on

Brave 1.45.121 Chromium: 107.0.5304.91 (Official Build) (64-bit)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS Ubuntu 18.04 LTS

BR (Brazilian) locale (new addition)

Case #1 - #26182

brave://welcome

Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

image
image
image

Case #2 - #26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows

image
image
image

Updated Profile (Google/Brave)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Google is still the default SE for Normal Windows
    • ensured that Google wasn't replaced by Brave for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows

image
image

Updated Profile (DDG/Startpage)
  • installed 1.45.118
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows

image
image
image

Updated Profile (Qwant/Bing)
  • installed 1.45.118
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows

image
image
image

en_GB locale (existing locale with Brave Search as default)

Case #1 - #26182

brave://welcome

Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

image
image
image

Case #2 - #26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows

image
image
image

Updated Profile (Brave/Brave)
  • installed 1.45.118
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Brave is still the default SE for Normal & PB windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows

image
image
image

Updated Profile (DDG/Startpage)
  • installed 1.45.118
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows

image
image
image

PL (Poland) locale (doesn't have Brave Search as default)

Case #1 - #26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

image

Case #2 - #26181

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows

image
image
image

Updated Profile (Google/Brave)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows

image
image
image

Updated Profile (Startpage/Bing)
  • installed 1.45.118
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows

image
image
image

RU (Russia) locale (Yandex as the default SE)

Case #1 - #26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

image

Case #2 - #26181

Clean Profile
  • ensured that Yandex was selected as the default for Normal windows via brave://settings/searchEngines
  • ensured that Brave was selected as the default for Private windows via brave://settings/searchEngines

image
image
image

Updated Profile (Yandex/Brave)
  • installed 1.45.118
  • ensured that Yandex was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that Yandex is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows

image
image
image

Updated Profile (Google/DDG)
  • installed 1.45.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.45.121 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave

image
image
image

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 14, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 14, 2022

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using:

Brave	1.45.125 Chromium: 107.0.5304.110 (Official Build) (64-bit) 
Revision	2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS	Android 12;

BR (Brazil) Locale

Google/Brave
  • installed 1.45.123
  • ensured that Google was the default SE for Normal tabs
  • ensured that Brave was the default SE for Private tabs
  • updated to 1.45.125 and ensured that Google is still the default SE for Normal tab
  • ensured that Google wasn't replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668527901695 screenshot-1668527989092
DDG/Startpage
  • installed 1.45.123
  • ensured that DDG was the default SE for Normal tabs
  • ensured that Startpage was the default SE for Private tabs
  • updated to 1.45.125 and ensured that DDG is still the default SE for Normal tab
  • ensured that DDG wasn't replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668527613401 screenshot-1668527702339
Qwant/Bing
  • installed 1.45.123
  • ensured that Qwant was the default SE for Normal tabs
  • ensured that Bing was the default SE for Private tabs
  • updated to 1.45.125 and ensured that Qwant is still the default SE for Normal tab
  • ensured that Qwant wasn't replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668527901695 screenshot-1668527989092

FR (France) Locale

Upgraded Profile (Brave/Brave)
  • installed 1.45.123
  • ensured that Brave was the default SE for Normal tabs
  • ensured that Brave was the default SE for Private tabs
  • updated to 1.45.125 and ensured that Brave is still the default SE for Normal & Private tabs
1.45.123 1.45.125
screenshot-1668528992545 screenshot-1668529060855
Upgraded Profile (DDG/Bing)
  • installed 1.45.123
  • updated default SE for Normal tabs to DDG
  • updated default SE for Private tabs to Bing
  • updated to 1.45.125 and ensured that DDG is still the default SE for Normal tab
  • ensured that DDG wasn't replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668529257963 screenshot-1668529331038

PL (Poland) Locale

Upgraded Profile (Google/Brave)
  • installed 1.45.123
  • ensured that Google was the default SE for Normal tabs
  • ensured that Google was the default SE for Private tabs
  • updated default SE for Private tabs to Brave
  • updated to 1.45.125 and ensured that Brave is still the default SE for Private tabs
1.45.123 1.45.125
screenshot-1668529796755 screenshot-1668529907553
Upgraded Profile (Bing/Bing)
  • installed 1.45.123
  • updated default SE for Normal tabs to Bing
  • updated default SE for Private tabs to Bing
  • updated to 1.45.125 and ensured that Bing is still the default SE for Normal tab
1.45.123 1.45.125
screenshot-1668530063318 screenshot-1668530104283

RU (Russia) Locale

Upgraded Profile (Yandex/Yandex)
  • installed 1.45.123
  • ensured default SE for Normal tabs to Yandex
  • ensured default SE for Private tabs to Yandex
  • updated to 1.45.125 and ensured that Yandex is still the default SE
1.45.123 1.45.125
screenshot-1668530370069
screenshot-1668530417842
Upgraded Profile (Google/Brave)
  • installed 1.45.123
  • updated default SE for Normal tabs to Google
  • updated default SE for Private tabs to Brave
  • updated to 1.45.125 and ensured that Google is still the default SE for normal and Brave is default SE for private tabs
1.45.123 1.45.125
screenshot-1668530656054 screenshot-1668530695499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment