Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warmup Filecoin Ledger account before transaction (uplift to 1.43.x) #14805

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Warmup Filecoin Ledger account before transaction (uplift to 1.43.x) #14805

merged 2 commits into from
Aug 28, 2022

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Aug 24, 2022 •
edited by kjozwiak
Loading

Uplift of #14767
Fixes brave/brave-browser#24824
Also fixed showing of error dialogs when sign with filecoin HW acc.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@cypt4 cypt4 requested a review from a team as a code owner August 24, 2022 16:59
@cypt4 cypt4 changed the title Warmup Filecoin Ledger account before transaction (uplift to 1.44.x) Warmup Filecoin Ledger account before transaction (uplift to 1.43.x) Aug 24, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 24, 2022
@cypt4
Copy link
Collaborator Author

cypt4 commented Aug 24, 2022

/build ios

@yrliou yrliou marked this pull request as draft August 24, 2022 20:38
@cypt4 cypt4 requested a review from yrliou August 25, 2022 07:02
@yrliou yrliou marked this pull request as ready for review August 25, 2022 15:29
yrliou
yrliou approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for 1.43.x specific fix

@cypt4 cypt4 force-pushed the pr14767_brave_24824_1.43.x branch from e2132e4 to 6caca67 Compare August 26, 2022 11:07
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Developer Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Linux
  • Verified able to submit transactions via Ledger for Filecoin
  • Encountered 25012

@kjozwiak kjozwiak added this to the 1.43.x - Release milestone Aug 28, 2022
kjozwiak
kjozwiak approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.43.x approved 👍 QA has verified the PR on Nightly as per #14805 (comment).

@kjozwiak kjozwiak merged commit fa1bebb into 1.43.x Aug 28, 2022
@kjozwiak kjozwiak deleted the pr14767_brave_24824_1.43.x branch August 28, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@yrliou yrliou yrliou approved these changes

Assignees

@cypt4 cypt4

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@cypt4 @brave-builds @srirambv @kjozwiak @yrliou