Warmup Filecoin Ledger account before transaction #14767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
nvonpentz
reviewed
Aug 23, 2022
| @@ -122,6 +122,10 @@ export default class FilecoinLedgerKeyring implements LedgerFilecoinKeyring { | |||
| Method: parsed.Method, | |||
| Params: parsed.Params | |||
| } | |||
|
|
|||
| // Accounts must be warmuped before signing. | |||
nvonpentz
approved these changes
Aug 23, 2022
|
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#24824
Otherwise there is an error "Must call getAccounts with to derive this from address before signing with it" or "Must call getAccounts with to derive this from address before signing with it"
Submitter Checklist:
Test Plan:
Test filecoin transaction from HW addr for mainnet and testnet