Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear window.name on cross-origin navigation #14024

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jun 30, 2022

Resolves brave/brave-browser#23798

follow-up to #13511 which (we now realize) was an incomplete fix

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

As per @pes10k, the same verification can be used as per brave/brave-browser#5910 (comment).

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner June 30, 2022 16:43
@pilgrim-brave pilgrim-brave self-assigned this Jun 30, 2022
@pilgrim-brave pilgrim-brave added this to the 1.42.x - Nightly milestone Jun 30, 2022
@pilgrim-brave pilgrim-brave merged commit 80a19c5 into master Jun 30, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_window_name_final_2_updated branch June 30, 2022 20:07
@pilgrim-brave pilgrim-brave restored the mpilgrim_window_name_final_2_updated branch June 30, 2022 20:12
brave-builds pushed a commit that referenced this pull request Jun 30, 2022
@kjozwiak kjozwiak deleted the mpilgrim_window_name_final_2_updated branch July 2, 2022 23:20
@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.43.3 Chromium: 103.0.5060.114 (Official Build) nightly (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 11 Version 21H2 (Build 22000.739)

Went through the STR/Cases mentioned via brave/brave-browser#5910 (comment).

Example Example
image image

Verification PASSED on Pixel 6 running iOS 13 using the following build(s):

Brave | 1.43.4 Chromium: 103.0.5060.114 (Official Build) canary (32-bit)
--- | ---
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Android 13; Build/TPB3.220617.002
Example Example
Screenshot_20220706-190922 Screenshot_20220706-190928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window.name should be cleared on cross-origin navigation
3 participants