Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.name should be cleared on cross-origin navigation #23798

Closed
pilgrim-brave opened this issue Jun 30, 2022 · 4 comments · Fixed by brave/brave-core#14024
Closed

window.name should be cleared on cross-origin navigation #23798

pilgrim-brave opened this issue Jun 30, 2022 · 4 comments · Fixed by brave/brave-core#14024
Assignees
@pilgrim-brave
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.41.x - Release

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Jun 30, 2022 •
edited
Loading

follow-up to #5910 which was closed with (what we now realize was) an incomplete fix
@pilgrim-brave
Copy link
Author

c.f. https://privacytests.org/

@pilgrim-brave pilgrim-brave mentioned this issue Jun 30, 2022
Merged
25 tasks
@pilgrim-brave pilgrim-brave self-assigned this Jun 30, 2022
@pilgrim-brave pilgrim-brave added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 30, 2022
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 30, 2022
@brave-builds brave-builds mentioned this issue Jun 30, 2022
Merged
7 tasks
@kjozwiak kjozwiak mentioned this issue Jul 6, 2022
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

The above will require 1.41.94 or higher for 1.41.x verification 👍 As mentioned via #5910 (comment), this is basically the same check re: running through https://dev-pages.bravesoftware.com/dom-properties/window-name.html.

@srirambv
Copy link
Contributor

srirambv commented Jul 7, 2022

Verification passed on the following devices running 1.41.91 x64 build

  • Verified window.name returns value NA on both the test pages
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
23798-ARM.mp4
23798-Tab.mp4

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 7, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jul 7, 2022 •
edited
Loading

Verified with

Brave | 1.41.94 Chromium: 103.0.5060.114 (Official Build) (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Reproduced the issue using 1.40.113:

Example Example
1 41 113A 1 40 113B

Confirmed does not reproduce when using 1.41.94:

Example Example
1 41 xA 1 41 xB

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 7, 2022
@moglerdev moglerdev mentioned this issue Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Clear window.name on cross-origin navigation brave/brave-core
5 participants
@kjozwiak @srirambv @LaurenWags @pilgrim-brave @brave-builds