Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopen sync code dialog when switching desktop <=> mobile (uplift to 1.41.x) #13812

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Reopen sync code dialog when switching desktop <=> mobile (uplift to 1.41.x) #13812

merged 1 commit into from
Jun 17, 2022

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jun 16, 2022 •
edited by kjozwiak
Loading

Uplift of #13643
Resolves brave/brave-browser#23262

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash requested a review from a team June 16, 2022 10:41
@AlexeyBarabash AlexeyBarabash self-assigned this Jun 16, 2022
@AlexeyBarabash AlexeyBarabash added this to the 1.41.x - Beta milestone Jun 16, 2022
@kjozwiak kjozwiak mentioned this pull request Jun 17, 2022
Merged
25 tasks
kjozwiak
kjozwiak approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.41.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#23262 (comment).

@kjozwiak kjozwiak merged commit 790b3b9 into 1.41.x Jun 17, 2022
@kjozwiak kjozwiak deleted the pr13643_sync_ui_add_device_freeze_1.41.x branch June 17, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
1.41.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak