Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to copy code words from existing sync chain #23262

Closed
GeetaSarvadnya opened this issue Jun 6, 2022 · 6 comments · Fixed by brave/brave-core#13643
Closed

Unable to copy code words from existing sync chain #23262

GeetaSarvadnya opened this issue Jun 6, 2022 · 6 comments · Fixed by brave/brave-core#13643

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 6, 2022

Description

Found while testing #22420
Unable to copy code words from existing sync chain

Steps to Reproduce

  1. Clean profile 1.40.x
  2. Create a sync chain between two devices
  3. Click on View Sync Code
  4. Copy QR code and confirm code words can be copied
  5. Click on View QR Code
  6. Click on View Sync Code
  7. Try to copy sync code, unable to copy sync code
  8. Click on close x on sync modal
  9. Sync modal popup is not dismissed
  10. Enter Esc button modal popup gets dismissed

Actual result:

Unable to copy code words from existing sync chain
unable to copy sync code

Expected result:

Should be able to copy sync code

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.40.83 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS Windows 10 Version 21H2 (Build 19044.1706)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @AlexeyBarabash @rebron @brave/qa-team

Reproduced by @srirambv

@AlexeyBarabash
Copy link
Contributor

thanks @GeetaSarvadnya , I also can reproduce it

@stephendonner
Copy link

Also reproduces on

Brave 1.41.39 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 11.6.6 (Build 20G624)

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 17, 2022

Verification PASSED using

Brave | 1.42.2 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Followed original steps.

Verified the fix, able to copy sync code

2022-06-16_17h11_08

@kjozwiak
Copy link
Member

Removing the QA Pass labels as this was uplifted into 1.40.x via brave/brave-core#13813 and should be rechecked. However, I used the verification that @MadhaviSeelam completed via #23262 (comment) as the Nightly verification for the uplifts as mentioned via brave/brave-core#13643 (comment).

The above will require 1.40.103 or higher for 1.40.x verification 👍

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 17, 2022

Verification PASSED on

Brave | 1.40.103 Chromium: 103.0.5060.53 (Official Build) (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1706)

  • Verified the STR from the description and ensured sync code words can be copied from the existing sync chain
    Sync code copy

Verification PASSED on

Brave	1.40.103 Chromium: 103.0.5060.53 (Official Build) (64-bit) 
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	Linux
  • Verified the STR from the description and ensured sync code words can be copied from the existing sync chain

@stephendonner
Copy link

Verified PASSED using

Brave 1.40.103 Chromium: 103.0.5060.53 (Official Build) (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)

Confirmed I could copy (and paste) code words
Confirmed I could join using code words
Confirmed I could join using QR code

example example example
Screen Shot 2022-06-17 at 9 46 56 AM Image from iOS Screen Shot 2022-06-17 at 9 46 59 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment