Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab mouseover for webpages that start with chrome #12882

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Apr 4, 2022

Resolves brave/brave-browser#22069

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Visit chromeunboxed.com
  • Verify that tab mouseover says chromeunboxed.com (not braveunboxed.com)
  • Visit brave://settings
  • Verify that tab mouseover says brave://settings (not chrome://settings)

@emerick emerick requested a review from mkarolin April 4, 2022 19:25
@emerick emerick requested a review from a team as a code owner April 4, 2022 19:25
@emerick emerick self-assigned this Apr 4, 2022
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 4, 2022
@emerick
Copy link
Contributor Author

emerick commented Apr 4, 2022

CI passed on all platforms but the "noplatform" step failed; will try to restart just that.

@emerick emerick force-pushed the fix-tab-mouseover-for-chrome-sites branch from 3c43b7c to bf07bd3 Compare April 4, 2022 23:47
@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 5, 2022
@emerick
Copy link
Contributor Author

emerick commented Apr 5, 2022

Noplatform step passed; ready to merge.

@emerick emerick merged commit e6557d1 into master Apr 5, 2022
@emerick emerick deleted the fix-tab-mouseover-for-chrome-sites branch April 5, 2022 10:41
@emerick emerick added this to the 1.39.x - Nightly milestone Apr 5, 2022
brave-builds pushed a commit that referenced this pull request Apr 11, 2022
brave-builds pushed a commit that referenced this pull request Apr 11, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.39.45 Chromium: 100.0.4896.79 (Official Build) nightly (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 11 Version 21H2 (Build 22000.593)
Example Example
fixedExample1 fixedExample2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab mouseover misnames web pages that begin with chrome
3 participants