Tab mouseover misnames web pages that begin with chrome

[alanhoyle]

Description

When a web site is at a domain that begins with "chrome" brave replaces "chrome" with "brave" in the tab's tool-tip that pops up with the mouse hovers over the tab.

Steps to Reproduce

1. Go to a web site that begins with "chrome" e.g. chromeunboxed.com or chromeosreview.com
2. Hover the mouse over the tab

Note that this is hard to grab a screenshot of at least on a mac. As soon as I hit any of the modifier keys required to take a screenshot, the tooltip disappears. I had to do a screen recording and take a screenshot of that.

Actual result:

The tooltip says "braveunboxed.com"

or "braveosreview.com"

Expected result:

The tooltip should say "chromeunboxed.com" or "chromeosreview.com"

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? untested.

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? no
• Does the issue resolve itself when disabling Brave Rewards? untested
• Is the issue reproducible on the latest version of Chrome? no

Miscellaneous Information:

My guess is that this is done by a naive regex like s/^chrome/brave/ when that should be something more like s/^chrome:\/\//brave:\/\//

[bsclifton]

cc: @mkarolin @emerick @cdesouza-chromium @samartnik

[kjozwiak]

Above requires 1.37.114 or higher for 1.37.x verification.

[LaurenWags]

Verified with

Brave | 1.37.114 Chromium: 100.0.4896.88 (Official Build) (x86_64)
-- | --
Revision | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS | macOS Version 12.3.1 (Build 21E258)

Reproduced the issue using 1.37.113:

Example	Example

Verified the test plan from brave/brave-core#12882 (comment)

Example	Example	Example

[alanhoyle]

I just updated to the latest Brave Beta on my Mac (Version 1.38.90 Chromium: 100.0.4896.79) and it's fixed there now.

Thank you for your time and attention!

[LaurenWags]

Great, thanks for the confirmation @alanhoyle 😄