Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pending transactions sometimes are not updated to confirmed (uplift to 1.37.x) #12566

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fix pending transactions sometimes are not updated to confirmed (uplift to 1.37.x) #12566

merged 1 commit into from
Mar 15, 2022

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Mar 10, 2022 •
edited by kjozwiak
Loading

Uplift of #12555
Resolves brave/brave-browser#21300

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@yrliou
Merge pull request #12555 from brave/fix_tx_not_updated_rebase
293e8e1 
Fix pending transactions sometimes are not updated to confirmed
@yrliou yrliou added this to the 1.37.x - Beta milestone Mar 10, 2022
@yrliou yrliou requested a review from a team March 10, 2022 17:56
@yrliou yrliou requested a review from a team as a code owner March 10, 2022 17:56
@yrliou yrliou self-assigned this Mar 10, 2022
kjozwiak
kjozwiak approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.37.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12555 (comment).

@kjozwiak kjozwiak merged commit c19f713 into 1.37.x Mar 15, 2022
@kjozwiak kjozwiak deleted the fix_submitted_tx_not_updated_1.37.x branch March 15, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@yrliou @kjozwiak