Transaction status is not updated sometimes for pending transactions

[Douglashdaniel]

Description

We have a transactionStatusChanged action that gets called by OnTransactionStatusChanged observer

handler.on(WalletActions.transactionStatusChanged.getType(), async (store: Store, payload: TransactionStatusChanged) => {
  const status = payload.txInfo.txStatus
  if (status === BraveWallet.TransactionStatus.Confirmed || status === BraveWallet.TransactionStatus.Error) {
    await refreshBalancesPricesAndHistory(store)
  }
})

which will update Balances if a transactions status has changed to Confirmed or Error.

Currently OnTransactionStatusChanged is not firing when a transactions status has changed to Confirmed until you lock and unlock the wallet.

[yrliou]

This issue is due to block tracker not being run so we didn't get the update. The reason that lock & unlock updates it is because when you unlock it would trigger the block tracker to start when there are pending transactions.

[yrliou]

See test plan in brave/brave-core#12555 (comment)

[kjozwiak]

Requires 1.37.94 or later for verification using 1.37.x.

[Uni-verse]

Verification completed on desktop using:

Brave | 1.37.102 Chromium: 99.0.4844.83 (Official Build) dev (x86_64)
-- | --
Revision | b11086e62d7c1a44b0942ac5568d22a425c7ae35-refs/branch-heads/4844_74@{#5}
OS | macOS Version 12.1 (Build 21C52)

Txn Hash: 0xee8bc52e4e9d59e4797fc73325aa074654ef86ef240e7b81348c75fb8955af56

Test Plan:
brave/brave-core#12555 (comment)

• Verified transaction status is updated to confirmed in brave://settings/wallet/accounts

[Uni-verse]

Verification completed on Android ARM using Beta 1.37.101, Chromium 99.0.4844.83

Devices:
Samsung Galaxy S21 running Android 12

Txn Hash: 0xc043b4f4d4bb8cc008883a68d4383ab4441e8fea5e3ceea59971b71064ab9abf

• Verified transaction status is updated to confirmed under wallet accounts

Submitted	Confirmed

Submitted (Tablet)	Confirmed (Tablet)

[Uni-verse]

Verification Completed on iOS using beta version 1.37 (22.3.22.17) BraveCore 1.37.101 (99.0.4844.83)

Test Devices:
iPhone 12 Pro | iOS 15.4
iPhone X | iOS 14.4.2
iPad (7th Gen) | iOS 15.2

• Verified transaction status is updated to confirmed under wallet accounts

iOS 15:

Submitted	Confirmed

iPad (iOS 15):

Submitted	Confirmed

iOS 14:

Submitted	Confirmed