Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign typed data (uplift to 1.33.x) #11256

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Sign typed data (uplift to 1.33.x) #11256

merged 1 commit into from
Nov 24, 2021

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 23, 2021 •
edited by kjozwiak
Loading

Uplift of #11206
fix brave/brave-browser#18659

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@darkdh darkdh added this to the 1.33.x - Beta milestone Nov 23, 2021
@darkdh darkdh requested a review from a team November 23, 2021 22:25
@darkdh darkdh self-assigned this Nov 23, 2021
@darkdh darkdh requested a review from a team as a code owner November 23, 2021 22:25
@kjozwiak
Copy link
Member

macOS failed on test-browser due to BraveWalletEthereumChainTest.AddChainAndCloseTab failing as per https://ci.brave.com/job/pr-brave-browser-pr11206_sign_typed_data_1.33.x-macos/1/testReport/. However, this is a known intermittent issue as per brave/brave-browser#19694 and will be fixed via #11253.

kjozwiak
kjozwiak approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit f67b2bc into 1.33.x Nov 24, 2021
@kjozwiak kjozwiak deleted the pr11206_sign_typed_data_1.33.x branch November 24, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @kjozwiak