Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement eth_signTypedData and in particular eth_signTypedData_v4 version of EIP-712 #18659

Closed
darkdh opened this issue Oct 8, 2021 · 4 comments · Fixed by brave/brave-core#11206
Closed

Implement eth_signTypedData and in particular eth_signTypedData_v4 version of EIP-712 #18659

darkdh opened this issue Oct 8, 2021 · 4 comments · Fixed by brave/brave-core#11206
Assignees
@darkdh
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Oct 8, 2021

https://eips.ethereum.org/EIPS/eip-712
@darkdh darkdh self-assigned this Oct 8, 2021
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Oct 29, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 3, 2021
@darkdh
Copy link
Member Author

darkdh commented Nov 9, 2021

"Unlock currency" in https://opensea.io/ now uses eth_signTypedData_v4
and also https://zed.run/

@bbondy bbondy mentioned this issue Nov 10, 2021
Merged
24 tasks
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 10, 2021
@bbondy bbondy changed the title Implement signTypedData Implement eth_signTypedData_v4 Nov 10, 2021
@bbondy bbondy changed the title Implement eth_signTypedData_v4 Implement eth_signTypedData and in particular eth_signTypedData_v4 version of EIP-712 Nov 10, 2021
@srirambv srirambv mentioned this issue Nov 18, 2021
Closed
@cruzdanilo
Copy link

kinda unbelievable that the new wallet was released without this functionality, effectively removing it from the old wallet.

@darkdh darkdh mentioned this issue Nov 22, 2021
Merged
24 tasks
@darkdh darkdh added this to the 1.34.x - Nightly milestone Nov 23, 2021
This was referenced Nov 23, 2021
Merged
Merged
@kjozwiak kjozwiak removed this from the 1.34.x - Nightly milestone Nov 24, 2021
@kjozwiak
Copy link
Member

Moving this back to 1.33.x as it was reverted from 1.32.x as per brave/brave-core#11277 due to causing #19719.

@srirambv srirambv mentioned this issue Nov 24, 2021
Closed
9 tasks
@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2021

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (arm64)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS macOS Version 12.0.1 (Build 21A559)
  • Verified test plan from Sign typed data brave-core#11206
  • Verified with same seed used on MM and BW, response is same
  • Verified when network is wrong console logs error
    image

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Windows 11 Version Dev (Build 22509.1000)
  • Verified test plan from Sign typed data brave-core#11206
  • Verified with same seed used on MM and BW, response is same
  • Verified when network is wrong console logs error
    image

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Linux
  • Verified test plan from Sign typed data brave-core#11206
  • Verified with same seed used on MM and BW, response is same
  • Verified when network is wrong console logs error
    image

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Sign typed data brave/brave-core
5 participants
@cruzdanilo @bbondy @kjozwiak @darkdh @srirambv