Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance toggle in New Tab Page section of settings should be removed for Japan or OFAC countries #9416

Closed
GeetaSarvadnya opened this issue Apr 23, 2020 · 1 comment · Fixed by brave/brave-core#5372

Comments

@GeetaSarvadnya
Copy link

Description

For Japan locale Binance option needs to be removed from brave://settings/newTab

Steps to Reproduce

  1. Set locale to Japan
  2. Open an NTP and make sure Binance widget is removed from NTP
  3. Open Dashboard settings and make sure Binance toggle is removed
  4. Navigate to brave://settings/newTab
  5. Binance option is still shown in brave://settings/newTab which needs to be removed

Actual result:

For Japan locale Binance option is still shown in brave://settings/newTab

image

Expected result:

For Japan locale Binance option needs to be removed from brave://settings/newTab

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.10.3 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? Yes in 1.9.38
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @ryanml @rebron

@srirambv srirambv changed the title For Japan locale Binance option needs to be removed from brave://settings/newTab Binance toggle in New Tab Page section of settings should be removed for Japan or OFAC countries Apr 23, 2020
@ryanml ryanml self-assigned this Apr 25, 2020
@ryanml ryanml added this to the 1.10.x - Nightly milestone Apr 25, 2020
ryanml added a commit to brave/brave-core that referenced this issue Apr 26, 2020
ryanml added a commit to brave/brave-core that referenced this issue May 7, 2020
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented May 27, 2020

Verification passed on


Brave | 1.10.72 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified STR from the description
    image

Verification passed on

Brave 1.10.81 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Linux
  • Verified steps from issue description
    image

Verification passed on

Brave 1.10.81 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified steps from issue description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment