Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binance NTP Widget should not be available for Japan or OFAC countries #8849

Closed
ryanml opened this issue Mar 25, 2020 · 1 comment · Fixed by brave/brave-core#5058
Closed

Binance NTP Widget should not be available for Japan or OFAC countries #8849

ryanml opened this issue Mar 25, 2020 · 1 comment · Fixed by brave/brave-core#5058
Assignees
@ryanml
Labels
feature/new-tab feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.8.x - Release

Comments

@ryanml
Copy link
Contributor

ryanml commented Mar 25, 2020 •
edited
Loading

The widget should not appear on the NTP for users with a Japanese or an OFAC country locale.
@ryanml ryanml added this to the 1.8.x - Nightly milestone Mar 25, 2020
@ryanml ryanml self-assigned this Mar 25, 2020
ryanml added a commit to brave/brave-core that referenced this issue Mar 25, 2020
@ryanml
Fixes brave/brave-browser#8849 - Hides Binance Widget for JP Users (A…
a8409c3 
…nonWallet)
@ryanml ryanml mentioned this issue Mar 25, 2020
Merged
32 tasks
@ryanml ryanml changed the title Binance NTP Widget should not be available for Japan Binance NTP Widget should not be available for Japan or OFAC countries Mar 26, 2020
ryanml added a commit to brave/brave-core that referenced this issue Mar 31, 2020
@ryanml
Fixes brave/brave-browser#8849 - Hides Binance Widget for JP Users (A…
3724c74 
…nonWallet) and OFAC countries (IsSupportedLocale)
@srirambv srirambv added feature/web3/wallet Integrating Ethereum+ wallet support feature/widgets labels Apr 22, 2020
@srirambv
Copy link
Contributor

srirambv commented Apr 28, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{# 963}
OS Linux
  • Verified on clean install there is no Binance widget on NTP and no option to show/hide in dashboard settings
  • Verified upgrading from 1.7.98 to 1.8.85 doesn't show Binance widget on NTP for JP locale
  • Verified on upgrade from 1.7.98 to 1.8.85 doesn't show Binance option in dashboard settings
  • Verified the following on nightly channel upgrade from 1.8.58_nightly
    • Binance on Rewards off in dashboard and upgrading to 1.10.11 removes Binance widget and setting from dashboard
    • Binance off Rewards off in dashboard and upgrading to 1.10.11 removes Binance widget and setting from dashboard
    • Binance on Rewards on in dashboard and upgrading to 1.10.11 removes Binance widget and setting from dashboard
    • Binance off Rewards off in dashboard and upgrading to 1.10.11 removes Binance widget and setting from dashboard

Verification PASSED on macOS 10.15.4 x64 Catalina using the following build:

Brave | 1.10.15 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

On a clean 1.8.85 Chromium: 81.0.4044.122 install, ensured the following:

  • Binance widget isn't being displayed under NTP when region is set as Japan
  • Binance widget isn't being displayed under NTP when region is set as Libya
  • Binance widget isn't being displayed under NTP when region is set as Zimbabwe

Ensured that the following upgrade cases worked as expected:

  • ensured that the Binance widget isn't being displayed when upgrading from 1.7.98 CR: 81.0.4044.113 to 1.8.85 Chromium: 81.0.4044.122 (Japan locale)
  • ensured that the Binance widget was removed from NTP when upgrading from 1.8.58 CR: 81.0.4044.83 to 1.10.15 CR: 81.0.4044.129 (Japan locale)
    • Binance enabled/Rewards disabled and ensured the binance widget was removed from NTP/dashboard settings
    • Binance disabled/Rewards disabled and ensured the binance widget wasn't being displayed under NTP/dashboard settings
    • Binance enabled/Rewards enabled and ensured the binance widget was removed from NTP/dashboard settings
    • Binance enabled/Rewards disabled and ensured the binance widget was removed from NTP/dashboard settings

Verification passed on

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

On a clean 1.8.86 Chromium: 81.0.4044.129 install, ensured the following:

  • Binance widget isn't being displayed under NTP when region is set as Japan

Ensured that the following upgrade cases worked as expected:

  • ensured that the Binance widget isn't being displayed when upgrading from 1.7.98 CR: 81.0.4044.113 to 1.8.86 Chromium: 81.0.4044.129 (Japan locale)
  • ensured that the Binance widget was removed from NTP when upgrading from 1.8.58 CR: 81.0.4044.83 to 1.10.15 CR: 81.0.4044.129 (Japan locale)
    • Binance enabled/Rewards disabled and ensured the binance widget was removed from NTP/dashboard settings
    • Binance disabled/Rewards disabled and ensured the binance widget wasn't being displayed under NTP/dashboard settings
    • Binance enabled/Rewards enabled and ensured the binance widget was removed from NTP/dashboard settings
    • Binance disabled/Rewards enabled and ensured the binance widget was removed from NTP/dashboard settings

@kjozwiak kjozwiak mentioned this issue May 5, 2020
Closed
@bbondy bbondy removed the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/new-tab feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Hides Binance Widget for JP Users and OFAC Countries brave/brave-core
7 participants
@bbondy @kjozwiak @bsclifton @ryanml @srirambv @LaurenWags @GeetaSarvadnya