Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted ads keep showing #8645

Closed
btlechowski opened this issue Mar 11, 2020 · 1 comment · Fixed by brave/brave-core#4944
Closed

Converted ads keep showing #8645

btlechowski opened this issue Mar 11, 2020 · 1 comment · Fixed by brave/brave-core#4944

Comments

@btlechowski
Copy link

Found while testing #6536.

The ads conversion is linked to creativeSetId. There could be many ads under one creativeSetId.
Any ad can convert the set, which is expected.
Not expected is that we keep showing ads from the set that was converted. Our clients may not like that because it is unnecessary cost.
According to @jsecretan this is expected behavior at this stage, but something we should definitely address in the future.

Steps to Reproduce

  1. Create a catalog with multiple ads under one creativeSetId
  2. Show the ad
  3. Convert the ad
  4. Trigger more ads from the set

Note: reproduced on staging

Actual result:

Ads keep showing for converted set

Expected result:

Ads are not showing

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @tmancey @jsecretan @rebron @davidtemkin

@btlechowski
Copy link
Author

btlechowski commented Apr 24, 2020

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS

Staging catalog used: 8645.txt
The issue still reproduces. Per our process I logged a new issue: #9436

Verified using

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

As noted above, issue still reproduces. Commented on #9436.

Verification passed on

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)

As noted above, issue still reproduces. Commented on #9436.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants