Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to #8645 - Converted ads keep showing #9436

Closed
btlechowski opened this issue Apr 24, 2020 · 3 comments · Fixed by brave/brave-core#5381
Closed

Follow up to #8645 - Converted ads keep showing #9436

btlechowski opened this issue Apr 24, 2020 · 3 comments · Fixed by brave/brave-core#5381
Assignees
@tmancey
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.9.x - Release

Comments

@btlechowski
Copy link

Follow up to #8645. The issue still reproduces.

Steps to Reproduce

  1. Create a catalog with multiple ads under one creativeSetId. Staging catalog: 8645.txt
  2. Run Brave with flags --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true --brave-ads-debug
  3. Show the ad
  4. Convert the ad
  5. Wait till next ad can be shown
  6. Trigger more ads from the set

Note: reproduced on staging

Actual result:

Ads keep showing for converted set
image

Expected result:

Ads are not showing

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS
Brave 1.10.3 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey @jsecretan @rebron
@btlechowski btlechowski added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes QA/Test-Plan-Specified feature/ads labels Apr 24, 2020
@btlechowski btlechowski mentioned this issue Apr 24, 2020
Closed
@LaurenWags
Copy link
Member

Reproduces on macOS

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

@tmancey tmancey self-assigned this Apr 25, 2020
@tmancey tmancey mentioned this issue Apr 27, 2020
Merged
32 tasks
@GeetaSarvadnya
Copy link

Reproduced on Windows 10 x64

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)

This was referenced Apr 27, 2020
Merged
Closed
@tmancey tmancey added this to the 1.10.x - Nightly milestone Apr 28, 2020
@kjozwiak kjozwiak added the OS/Android Fixes related to Android browser functionality label May 5, 2020
@btlechowski
Copy link
Author

btlechowski commented May 12, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified that the second ad is not shown.
Verified creativeSetId (...) has exceeded the frequency capping for conversions is present in the logs when attempt is made to shown the second ad.

[8262:1:0512/050610.507828:INFO:ads_impl.cc(359)] Browser state changed to unidle
[8262:1:0512/050610.521400:INFO:ads_impl.cc(946)] Serving ad from categories:
[8262:1:0512/050610.521571:INFO:ads_impl.cc(948)]   technology & computing-technology & computing
[8262:1:0512/050610.521746:INFO:ads_impl.cc(948)]   technology & computing-software
[8262:1:0512/050610.521890:INFO:ads_impl.cc(948)]   arts & entertainment-video games
[8262:1:0512/050610.522778:INFO:ads_impl.cc(966)] No eligible ads found in categories:
[8262:1:0512/050610.522953:INFO:ads_impl.cc(968)]   technology & computing-technology & computing
[8262:1:0512/050610.523109:INFO:ads_impl.cc(968)]   technology & computing-software
[8262:1:0512/050610.523253:INFO:ads_impl.cc(968)]   arts & entertainment-video games
[8262:1:0512/050610.523399:INFO:ads_impl.cc(999)] Serving ad from parent categories:
[8262:1:0512/050610.523540:INFO:ads_impl.cc(1001)]   technology & computing
[8262:1:0512/050610.523728:INFO:ads_impl.cc(1001)]   arts & entertainment
[8262:1:0512/050610.524649:INFO:ads_impl.cc(1180)] All advertisers have been shown, so round robin
[8262:1:0512/050610.524774:INFO:client.cc(420)] Resetting seen advertisers
[8262:1:0512/050610.525683:INFO:ads_impl.cc(1122)] creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions
[8262:1:0512/050610.525790:INFO:ads_impl.cc(966)] No eligible ads found in categories:
[8262:1:0512/050610.525942:INFO:ads_impl.cc(968)]   technology & computing
[8262:1:0512/050610.526084:INFO:ads_impl.cc(968)]   arts & entertainment
[8262:1:0512/050610.526271:INFO:ads_impl.cc(1012)] Serving ad notification from untargeted category
[8262:1:0512/050610.532903:INFO:client.cc(593)] Successfully saved client state
[8262:1:0512/050610.533283:INFO:ads_impl.cc(1072)] Notification not made: No eligible ads found

Verification passed on


Brave | 1.9.63 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from the description
Verified that the second ad is not shown.
Verified creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions is present in the logs when attempt is made to shown the second ad.

[11468:15700:0512/215032.368:INFO:ads_impl.cc(359)] Browser state changed to unidle
[11468:15700:0512/215032.380:INFO:ads_impl.cc(946)] Serving ad from categories:
[11468:15700:0512/215032.380:INFO:ads_impl.cc(948)]   technology & computing-technology & computing
[11468:15700:0512/215032.380:INFO:ads_impl.cc(948)]   technology & computing-software
[11468:15700:0512/215032.380:INFO:ads_impl.cc(948)]   arts & entertainment-video games
[11468:15700:0512/215032.381:INFO:ads_impl.cc(966)] No eligible ads found in categories:
[11468:15700:0512/215032.381:INFO:ads_impl.cc(968)]   technology & computing-technology & computing
[11468:15700:0512/215032.381:INFO:ads_impl.cc(968)]   technology & computing-software
[11468:15700:0512/215032.381:INFO:ads_impl.cc(968)]   arts & entertainment-video games
[11468:15700:0512/215032.381:INFO:ads_impl.cc(999)] Serving ad from parent categories:
[11468:15700:0512/215032.381:INFO:ads_impl.cc(1001)]   technology & computing
[11468:15700:0512/215032.381:INFO:ads_impl.cc(1001)]   arts & entertainment
[11468:15700:0512/215032.382:INFO:ads_impl.cc(1122)] creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions
[11468:15700:0512/215032.382:INFO:ads_impl.cc(966)] No eligible ads found in categories:
[11468:15700:0512/215032.382:INFO:ads_impl.cc(968)]   technology & computing
[11468:15700:0512/215032.382:INFO:ads_impl.cc(968)]   arts & entertainment
[11468:15700:0512/215032.382:INFO:ads_impl.cc(1012)] Serving ad notification from untargeted category
[11468:15700:0512/215032.382:INFO:ads_impl.cc(1072)] Notification not made: No eligible ads found

Verified passed with

Brave | 1.9.71 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from the description
Verified that the second ad is not shown.
Verified creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions is present in the logs when attempt is made to shown the second ad.

[9861:775:0520/131037.707805:INFO:ads_impl.cc(359)] Browser state changed to unidle
[9861:775:0520/131037.715280:INFO:ads_impl.cc(946)] Serving ad from categories:
[9861:775:0520/131037.715475:INFO:ads_impl.cc(948)]   technology & computing-technology & computing
[9861:775:0520/131037.715629:INFO:ads_impl.cc(948)]   technology & computing-software
[9861:775:0520/131037.715778:INFO:ads_impl.cc(948)]   arts & entertainment-video games
[9861:775:0520/131037.716887:INFO:ads_impl.cc(966)] No eligible ads found in categories:
[9861:775:0520/131037.717106:INFO:ads_impl.cc(968)]   technology & computing-technology & computing
[9861:775:0520/131037.717334:INFO:ads_impl.cc(968)]   technology & computing-software
[9861:775:0520/131037.717622:INFO:ads_impl.cc(968)]   arts & entertainment-video games
[9861:775:0520/131037.717863:INFO:ads_impl.cc(999)] Serving ad from parent categories:
[9861:775:0520/131037.718020:INFO:ads_impl.cc(1001)]   technology & computing
[9861:775:0520/131037.718165:INFO:ads_impl.cc(1001)]   arts & entertainment
[9861:775:0520/131037.718831:INFO:ads_impl.cc(1180)] All advertisers have been shown, so round robin
[9861:775:0520/131037.719022:INFO:client.cc(420)] Resetting seen advertisers
[9861:775:0520/131037.719270:INFO:ads_impl.cc(1122)] creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions
[9861:775:0520/131037.719432:INFO:ads_impl.cc(966)] No eligible ads found in categories:
[9861:775:0520/131037.719588:INFO:ads_impl.cc(968)]   technology & computing
[9861:775:0520/131037.719734:INFO:ads_impl.cc(968)]   arts & entertainment
[9861:775:0520/131037.719877:INFO:ads_impl.cc(1012)] Serving ad notification from untargeted category
[9861:775:0520/131037.732300:INFO:client.cc(593)] Successfully saved client state
[9861:775:0520/131037.732659:INFO:ads_impl.cc(1072)] Notification not made: No eligible ads found

@LaurenWags LaurenWags mentioned this issue May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.9.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes converted ads keep showing brave/brave-core
7 participants
@tmancey @kjozwiak @rebron @SergeyZhukovsky @LaurenWags @btlechowski @GeetaSarvadnya