Ad conversion detection fails if the target URL of the last shown ad matches the conversion URL pattern

[tmancey]

Description

Ad conversion detection fails if the target URL of the last shown ad matches the conversion URL pattern

Steps to Reproduce

1. View an ad
2. Navigate to a URL which matches the conversion URL pattern as defined in the ad catalog with the observation window

Actual result:

Ad conversion is not detected

Expected result:

Ad conversion should be detected

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.5.54+

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? Yes
• Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

  { 
	 "observationWindow":86400,
	 "urlPattern":"https://travala.com/booking?check_in=*",
	 "type":"postview"
  }
],

Search for `Started ad conversion timer for` and once the timer triggers then search for `Ad conversion for`

[btlechowski]

Verification passed on

Brave	1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision	fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS	Ubuntu 18.04 LTS

Verified following patterns:
[FAIL] Logged #8648
urlPattern: https://travala.com
targetUrl: https://travala.com

[PASS]
urlPattern: https://travala.com/
targetUrl: https://travala.com/

[PASS]
urlPattern: https://travala.com/booking/
targetUrl: https://travala.com/*/

Verification passed on

Brave	1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision	fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified the above patterns

[kjozwiak]

Thanks for running through this @btlechowski. Going to remove the labels as this will need to be rechecked on 1.5.x once brave/brave-core#4719 gets uplifted.

[btlechowski]

Verification passed on

Brave	1.5.111 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision	fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS	Ubuntu 18.04 LTS

Verification passed on

Brave	1.5.111 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision	fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified conversions for ads from different sets with matching url pattern
Catalog: different sets matching patterns.txt

• Verified when view->conversion were done one after another
  Both ads were converted
• Verified when view was done at the same time and the conversion after the views
  Both ads were converted

Verified conversions for ads from the same set with matching url pattern
Catalog: same set matching patterns.txt

• Verified when view->conversion were done one after another
  First ad was converted (expected). Second ad was shown (not expected). Logged Converted ads keep showing #8645
• Verified when view->conversion were done at the same time
  First ad shown, but not converted (expected). Second ad was converted.

Also verified #8362 (comment)

---

Verified passed with

Brave	1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision	fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS	macOS Version 10.14.6 (Build 18G3020)

PASS Verified conversions for ads from different sets with matching url pattern
Catalog: different sets matching patterns.txt

• Verified when view->conversion were done one after another. Both ads were converted.
• Verified when view was done at the same time and the conversion after the views. Both ads were converted.
• Additional testing done with Implement ad conversion attribution for Brave Ads #6536 (comment)

PASS Verified conversions for ads from the same set with matching url pattern
Catalog: same set matching patterns.txt

• Verified when view->conversion were done one after another. First ad was converted (expected). Second ad was shown, encountered Converted ads keep showing #8645
• Verified when view->conversion were done at the same time. First ad shown, but not converted (expected). Second ad was converted.