Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Saved passwords are not shown in brave://settings/passwords #3196

Closed
kenthunt opened this issue Feb 2, 2019 · 72 comments · Fixed by brave/brave-core#5656
Closed

[Desktop] Saved passwords are not shown in brave://settings/passwords #3196

kenthunt opened this issue Feb 2, 2019 · 72 comments · Fixed by brave/brave-core#5656
Assignees
@bsclifton @simonhong
Labels
bug feature/password-manager OS/Linux OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA/Yes release-notes/include
Milestone
1.11.x - Release #1

Comments

@kenthunt
Copy link

kenthunt commented Feb 2, 2019 •
edited by simonhong
Loading

New issue description (edit by bsclifton)

Passwords are definitely being saved by the browser, however they are not showing up under brave://settings/passwords

Original issue description

I installed the new Brave Browser version, and after that no longer can view saved passwords. Import does not work from Brave Browser. I can verify that the passwords are in "Login Data" and that if I visit a website, it will populate the username and password.

Steps to Reproduce (edit by simonhong)

Scenario 1: (Not a valid STR because we don't support muon anymore - simonhong)

  1. Install New Brave Browser
  2. Observe your old Brave Browser does not show you passwords anymore
  3. Import passwords from Brave (old) does not work in new Brave Browser

Scenario 2:

  1. Save some passwords by using Chrome and copy chrome's Login Data in user's profile folder to Brave's folder
  2. Launch Brave and checks Saved Passwords section(brave://settings/passwords) is empty
  3. Update and save some passwords by revisiting some websites
  4. Check Saved Passwords section displays newly added passwords

Actual result:

I have lost the ability to export individual passwords as needed from Brave. The passwords are still there.

Expected result:

Brave provides interactive access to saved passwords. New Brave Browser imports the old passwords successfully.

Reproduces how often:

Tried this once. Now am stuck with a website that is timing out and cannot export password to try a different computer / brave install.

Brave version (brave://version info)

Brave: 0.25.302
V8: 6.9.427.23
rev: 91cc80471c0afe6a2306357177ab8680a439be69
Muon: 8.1.8
OS Release: 17.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 69.0.3497.100

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Have not tried this.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?
    No this is a Brave defect.

Additional Information

I may have said no when asked during New Brave Browser to import all old settings. I'm not sure...
@kenthunt
Copy link
Author

kenthunt commented Feb 2, 2019

Same behavior with the current Beta Brave version. Does not import existing Brave (old) passwords.

@srirambv
Copy link
Contributor

srirambv commented Feb 9, 2019

Are you still able to use the saved passwords on muon browser even though its not visible in the about:passwords page? If its working then can you try closing muon and then trying to import passwords into brave-core?

@srirambv srirambv added feature/importer needs-more-info The report requires more detail before we can decide what to do with this issue. labels Feb 9, 2019
@sharifzadesina
Copy link

Same here.
It is always like this:
"Saved password will appear here"
But nothing appears.

59557082-9dd86c80-8fe5-11e9-81c5-f8399a5b16cf

@sharifzadesina sharifzadesina mentioned this issue Jun 18, 2019
Closed
@bcehprx
Copy link

bcehprx commented Jun 18, 2019

I just tried installing Brave Version 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit) on Ubuntu 18.04.1 LTS. I used the save password popup and I can see the website and password entry in the setting "Saved Passwords", and clicking on the show password eye icon reveals it. In passing, I was not asked for a machine login password, as I am with Windows.

@bcehprx
Copy link

bcehprx commented Jun 18, 2019

I also closed the browser and re-opened it, and the entry was still in "Saved Passwords".

@erezrokah
Copy link

erezrokah commented Jul 15, 2019 •
edited
Loading

I'm having the same issue of Brave stopping to show/save my passwords:
image

Also, Brave offers to save passwords, but when I click save the password is not added to the list:
image

The only solution I found is to create a new profile (Manage people->Add person) but then I lose all my existing passwords

I'm using Brave | 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit) on Ubuntu 18.04.2 LTS

@simurgh9
Copy link

I have the same problem in Version 0.68.138 Chromium: 77.0.3865.75 (Official Build) (64-bit). Also, it looks like it deletes some saved passwords at times like I had GitHub's password saved and it did not have it. I also had issues trying to import passwords from chrome. I tried manually copying the password files, which did not work either. Right now, it saves passwords fine and prompts to auto-fill them but does not show them indexed in the manage passwords portion of settings.

@yfrommelt
Copy link

Same in Version 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)

@szxyks
Copy link

szxyks commented Jan 5, 2020

I have the same issue.
The password is saved on a particular site but when searching for it in the preferences, it is totally empty.
So I have to reset the password so I can log into another device

@webargus
Copy link

webargus commented Jan 5, 2020

I'm having the same problem.

@HakeemIshak
Copy link

I'm also experiencing the same problem, can use my saved password but cannot view list of "Saved Password"

@bsclifton
Copy link
Member

I'm seeing this too- I definitely have saved passwords, but they aren't showing

This issue was originally tracking the use-case where people would import from the older "Muon" based Brave browser into this new Brave Core version. But the issue is definitely bigger than that. Going to re-characterize this issue a bit

cc: @rebron @kjozwiak @LaurenWags - curious if you all have ran into this?

@bsclifton bsclifton added feature/password-manager bug priority/P3 The next thing for us to work on. It'll ride the trains. and removed needs-more-info The report requires more detail before we can decide what to do with this issue. feature/importer labels Jan 29, 2020
@bsclifton bsclifton changed the title Brave no longer shows my saved passwords in Preferences--Security--Manage Passwords Saved passwords are not being shown in brave://settings/passwords Jan 29, 2020
@BachoSeven
Copy link

BachoSeven commented Jan 31, 2020 •
edited
Loading

Same issue here- Brave Beta Browser latest release, passwords were imported and I saved passwords but it asks to save them again; and in settings they don't show up

EDIT: For future reference, my problem got fixed by itself some time after, I guess sometimes it just takes some time for the imported passwords to show up. Also, I switched to nightly and never had the issue again

EDIT: Aaand of course now that I edited the post they stopped showing again...

@pixmix
Copy link

pixmix commented Feb 6, 2020 •
edited
Loading

I see the issue here already for several weeks. Password are actually recorded, but are not visible in the management interface.

Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
running on Linux [user] 4.15.0-76-generic #86~16.04.1-Ubuntu SMP Mon Jan 20 11:02:50 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

@michaeltintiuc
Copy link

Just happened to me with Version 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit) On Linux, it used to work with 1.2.x

@ghost
Copy link

ghost commented Feb 18, 2020

Yup, very similar to the behavior reported before. Plus, in some cases the saved password aren't automatically filled in the login form (I can't tell why it works for some sites and not the others).
I am on
Version 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)

It is unfortunate, that what seems to be major issue hasn't been addressed for over a year now.

@scorpion35
Copy link

scorpion35 commented Feb 21, 2020 •
edited
Loading

I am on a mac and was using Brave for over an year without an issues. Suddenly last week all my passwords were gone. This is what I've done to resolve the issue -

Removed these -

  1. /Applications/Brave Browser.app
  2. ~/Library/Application Support/BraveSoftware/

Downloaded Brave from Chrome browser (oh Chrome, what happened to you? Used to open IE to download Chrome. And now opened Chrome just to download Brave). New installation is saving passwords correctly. Unfortunately though, I need to visit lot of pages and save passwords again, but it's at least working.

@bsclifton
Copy link
Member

@scorpion35 interesting- seems to point at the profile being corrupt (ex: profile is what's under ~/Library/Application Support/BraveSoftware/). I believe the passwords are stored in a sqlite DB - maybe there is a file with metadata that is not up to date. The passwords are clearly there (logins work), just not showing on the page

@HakeemIshak
Copy link

HakeemIshak commented Feb 26, 2020 •
edited
Loading

I'm on Linux, I managed to see back my password by removing only the sqlite DB (Login Data). But of course I had to saved back my password to see it again

[removed] /home/{username}/.config/BraveSoftware/Brave-Browser/Default/Login Data

Probably something went wrong with the file.

Edit :
Found one trick to restore previous ones is to export/import them to new DB. But I suspect certain password field is corrupted which causing it to not appear in Password Manager. Once I manually fix the corrupted ones (set it empty), I managed to see back all the password saved.

@bsclifton
Copy link
Member

@simonhong created a bug upstream - discussion taking place there with code owners:
https://bugs.chromium.org/p/chromium/issues/detail?id=1086348

@tangodev
Copy link

I'm so happy @bsclifton and @simonhong that the issue is getting more traction! 😄

However: how does the encryption of the db relate to reinstalling / swapping PCs on Ubuntu Linux?

The first time I've noticed this issue was when I had a system crash and reinstalled. I restored my data from backups, but only Brave wasn't working correctly. Should I ensure that when I'm creating a new user profile in Ubuntu that I set the same user password? Or, does Brave use some hash that's unique to my installation and even if I take care to set the same Ubuntu user password, Brave will still fail to decrypt the db, because every single installation is unique in that regard?

A crash course on how this works (or a link to one) would be appreciated!

@matthewmarcus
Copy link

@bsclifton @simonhong - Thanks for your research and updates. Progress! Appreciate you guys.

So, to be clear, it's never going to be possible to view existing saved passwords, correct? Or is there something I can do (manually) to be able to see those once Simon's PR is included in the next release?

I downloaded and installed SQLite so I could view the Login Data file. Is there something I can do in there to make it possible to see all my passwords when the update is released?

@simonhong
Copy link
Member

So, to be clear, it's never going to be possible to view existing saved passwords, correct? Or is there something I can do (manually) to be able to see those once Simon's PR is included in the next release?

@matthewmarcus If you delete Login Data file, you can see newly saved passwords after deletion.
If you don't delete, you can see newly saved passwords with my PR.

I downloaded and installed SQLite so I could view the Login Data file. Is there something I can do in there to make it possible to see all my passwords when the update is released?

I think there is no way to see your decryption failed pwd.

@simonhong
Copy link
Member

However: how does the encryption of the db relate to reinstalling / swapping PCs on Ubuntu Linux?

I didn't see deeply about how encryption key is generated.
@tangodev If you have interests about how brave/chromium encrypt key for decrypting pwd in linux, GetEncryptionKey() is for you. :)

@matthewmarcus
Copy link

I think there is no way to see your decryption failed pwd.

Bummer. That is the biggest issue of all. I've probably got 200 saved passwords that are now pretty much lost. :-/

Would be cool if a dev could come up with a way to retrieve them. Even a hack. A lot of people dealing with this situation.

@simonhong
Copy link
Member

@matthewmarcus If Brave autofills to passwords forms, you can see them and export them with my PR. Thant means you've updated passwords with current encryption key in login db. Other encrypted with old encryption key will not be used. I think it's hard to know the old encryption key.

@matthewmarcus
Copy link

Why was this issue closed? The problem still exists.

@simonhong I updated to the most recent release of Brave and tried to save a new password. It is not being displayed in brave://settings/passwords.

Was your PR included in the latest release?

Version 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)

@simonhong
Copy link
Member

@matthewmarcus This fix will currently available only for nightly channel(1.11.x).
You can get this fix when 1.11.x goes stable channel.

@LaurenWags
Copy link
Member

LaurenWags commented Jun 18, 2020 •
edited by kjozwiak
Loading

Verified passed with macOS 10.14.6 Mojave using

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | macOS Version 10.14.6 (Build 18G3020)

cc @kjozwiak to check on macOS Catalina

Verified passed with Linux (Ubuntu 16.04) using

Brave	1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

Verification PASSED on macOS 10.15.5 x64 Catalina using the following build:

Brave | 1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
--- | ---
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.15.5 (Build 19F101)

@simonhong simonhong mentioned this issue Jun 24, 2020
Closed
@rebron rebron changed the title Saved passwords are not being shown in brave://settings/passwords [Desktop] Saved passwords are not shown in brave://settings/passwords Jul 14, 2020
@LaurenWags LaurenWags mentioned this issue Jul 15, 2020
Closed
@Psijic
Copy link

Psijic commented Jul 20, 2020 •
edited
Loading

Can't see saved passwords in Brave, Linux OpenSUSE 15.2
1.10.97 Chromium: 83.0.4103.116 (64-bit)

All is ok with 1.11.97 Chromium: 84.0.4147.89

@TripleSpeeder
Copy link

Finally got 1.11.97 on Arch linux and rejoice, passwords are there! Thanks guys 👍

@matthewmarcus
Copy link

Finally got 1.11.97 on Arch linux and rejoice, passwords are there! Thanks guys 👍

Same! I just updated Brave and can see all of my passwords. Not just recently saved ones, but all of them. So, how did y'all get around the encrypted DB issue? I understood that we'd never be able to see old saved passwords. Just new ones after the fix was implemented.

Regardless, thank you for implementing this fix! Much gratitude and many kudos.

@szxyks
Copy link

szxyks commented Jul 23, 2020 via email

@rebron rebron mentioned this issue Jul 31, 2020
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Sep 3, 2020

Is this fix implemented only for Arch Linux users?

It was also fixed on macOS 👍 If you take a look at the labels, you'll notice the issue has both OS/Linux and OS/macOS which indicates the affected platforms. We also QA'd and verified the fix on both Linux & macOS as per #3196 (comment).

@Aybee5
Copy link

Aybee5 commented Jul 17, 2023

I am facing this issue recently on my Ubuntu 22.04
Brave version: Version 1.52.130 Chromium: 114.0.5735.198 (Official Build) (64-bit)
OS: Ubuntu 22.04

When I signup for a page and saved the password, the password gets saved, but when I tried opening the brave://settings/passwords it shows empty and I can't view the passwords.

@kjozwiak
Copy link
Member

I am facing this issue recently on my Ubuntu 22.04 Brave version: Version 1.52.130 Chromium: 114.0.5735.198 (Official Build) (64-bit) OS: Ubuntu 22.04

When I signup for a page and saved the password, the password gets saved, but when I tried opening the brave://settings/passwords it shows empty and I can't view the passwords.

@Aybee5 I would create a new issue using the template here. The above is a pretty old issue and was fixed ~2 years ago. When creating a new issue, please make sure you add as much information as possible including STR (steps to reproduce) if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

@simonhong simonhong

Labels
bug feature/password-manager OS/Linux OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixed Saved Passwords section in settings is empty brave/brave-core