Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Backed Up Transactions Warning #12439

Closed
wants to merge 1 commit into from

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Feb 28, 2022

Description

Implemented a Backed Up Transactions Warning

In the case that user has submitted a transaction and the miners are not able to pick it up due to low submitted gas.
This warning will show if a user attempts to create another transaction and the old Submitted one is over 24 hours old.

  1. If user chooses too Clear and continue we override the old transaction by setting the nonce of the new Unapproved transaction to the nonce of the old stuck Submitted transaction.
  2. If the user chooses to not Clear and continue we treat the new Unapproved transaction as normal.
  3. If a user has multiple Unapproved transactions in queue, the first transactions will display the warning with the Clear and continue option. If chosen the next Unapproved transactions will show the same warning with out the Clear and continue option until the first transaction is Confirmed on the blockchain.

Resolves brave/brave-browser#21051

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Working.Example.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 28, 2022 22:57
@Douglashdaniel Douglashdaniel self-assigned this Feb 28, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 28, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

josheleonard
josheleonard previously approved these changes Mar 1, 2022
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel
Copy link
Contributor Author

Closing this PR as invalid since this issue has since been addressed by the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropped transactions are never retired in our Wallet
4 participants