Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide UI elements related to IdleDetection #18409

Closed
pes10k opened this issue Sep 28, 2021 · 5 comments · Fixed by brave/brave-core#10299
Closed

Hide UI elements related to IdleDetection #18409

pes10k opened this issue Sep 28, 2021 · 5 comments · Fixed by brave/brave-core#10299
Assignees
Labels

Comments

@pes10k
Copy link
Contributor

pes10k commented Sep 28, 2021

Following up from #18269 (comment), Brave currently disables the Idle Detection API, but doesn't remove the UI elements / settings around it, causing confusion.

To prevent confusion, we should just hide the UI elements related to the Idle Detection API

@pes10k pes10k added OS/Android Fixes related to Android browser functionality privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. OS/Desktop labels Sep 28, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Sep 28, 2021
@mkarolin mkarolin self-assigned this Sep 28, 2021
@mkarolin
Copy link
Contributor

mkarolin commented Sep 28, 2021

QA verification steps (Desktop):

  1. Start Brave and navigate to any site (e.g. cnn.com)
  2. Navigate to brave://settings "Privacy and security" "Site and Shields Settings"
  3. Under "Permissions" section, click on "Additional permissions"
  4. Verify that "Your device use" item is not present
  5. Scroll back to the top of the page and click on "View permissions and data stored across sites"
  6. Pick the site you visited in step 1 and click to expand
  7. Click on the site
  8. Verify that "Your device use" item is not present
  9. Navigate to brave://settings/content/idleDetection
  10. Verify that the page is empty.

Verify that the UI is not hidden when the feature is enabled:

  1. Start Brave from the command line with --enable-features=IdleDetection
  2. Repeat steps above, expect the reverse in the Verify steps.

QA verification steps (Android):

STR/Cases can be found via brave/brave-core#10299 (comment).

@mkarolin mkarolin removed the OS/Android Fixes related to Android browser functionality label Sep 28, 2021
@mkarolin
Copy link
Contributor

Split out Android into a separate issue: #18414

@kjozwiak
Copy link
Member

kjozwiak commented Oct 5, 2021

Going to change this from release-note/exclude --> release-notes/include as we're removing UI elements. @rebron @LaurenWags if you feel differently, please feel free to change it back 👍

@kjozwiak kjozwiak added the OS/Android Fixes related to Android browser functionality label Oct 6, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 6, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.31.73 Chromium: 94.0.4606.71 (Official Build) beta (x86_64)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. Start Brave and navigate to any site (e.g. cnn.com)
  2. Navigate to brave://settings "Privacy and security" "Site and Shields Settings"
  3. Under "Permissions" section, click on "Additional permissions"
  4. Verify that "Your device use" item is not present
  5. Scroll back to the top of the page and click on "View permissions and data stored across sites"
  6. Pick the site you visited in step 1 and click to expand
  7. Click on the site
  8. Verify that "Your device use" item is not present
  9. Navigate to brave://settings/content/idleDetection
  10. Verify that the page is empty.
example example example
Screen Shot 2021-10-06 at 1 09 41 PM Screen Shot 2021-10-06 at 1 11 01 PM Screen Shot 2021-10-06 at 1 11 21 PM

Verify that the UI is not hidden when the feature is enabled:

  1. Start Brave from the command line with --enable-features=IdleDetection
  2. Repeat steps above, expect the reverse in the Verify steps.
example example example
Screen Shot 2021-10-06 at 1 13 43 PM Screen Shot 2021-10-06 at 1 12 40 PM Screen Shot 2021-10-06 at 1 14 16 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 6, 2021
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.31.81 x64 Beta build

Verified when IdleDetection there is no permission that is asked on site settings
  • Verified visiting https://idle-detection.glitch.me, Idle Detection API is disabled
  • Verified that there's no UI associated with Idle Detection visible under Settings -> Site Settings
  • Verified that there's no UI associated with Idle Detection visible under Settings -> Site Settings -> All Sites
image image image
Verified when IdleDetection enabled via command line args, site permission is requested and added to site settings
  • Launched Brave using --enable-features=IdleDetection command line args
  • Verified visiting https://idle-detection.glitch.me detects IdleDetection API being enabled
  • Verified selecting the checkbox on the page presents Idle Detection API permission modal
  • Verified Your device use appears under All Sites under Site Settings for https://idle-detection.glitch.me
  • Verified disabling Idle Detection by removing --enable-features=IdleDetection removes the UI from All Sites
image image

Verification passed on Samsung Tab A with Android 10 running 1.31.81 x64 Beta build

Verified when IdleDetection there is no permission that is asked on site settings
  • Verified visiting https://idle-detection.glitch.me, Idle Detection API is disabled
  • Verified that there's no UI associated with Idle Detection visible under Settings -> Site Settings
  • Verified that there's no UI associated with Idle Detection visible under Settings -> Site Settings -> All Sites
image image image
Verified when IdleDetection enabled via command line args, site permission is requested and added to site settings
  • Launched Brave using --enable-features=IdleDetection command line args
  • Verified visiting https://idle-detection.glitch.me detects IdleDetection API being enabled
  • Verified selecting the checkbox on the page presents Idle Detection API permission modal
  • Verified Your device use appears under All Sites under Site Settings for https://idle-detection.glitch.me
  • Verified disabling Idle Detection by removing --enable-features=IdleDetection removes the UI from All Sites
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants