Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Hide UI elements related to IdleDetection #18414

Closed
mkarolin opened this issue Sep 28, 2021 · 1 comment
Closed

[Android] Hide UI elements related to IdleDetection #18414

mkarolin opened this issue Sep 28, 2021 · 1 comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium.

Comments

@mkarolin
Copy link
Contributor

Split out Android from #18409.

Following up from #18269 (comment), Brave currently disables the Idle Detection API, but doesn't remove the UI elements / settings around it, causing confusion.

To prevent confusion, we should just hide the UI elements related to the Idle Detection API

@mkarolin mkarolin added the OS/Android Fixes related to Android browser functionality label Sep 28, 2021
@mkarolin mkarolin changed the title Hide UI elements related to IdleDetection [Android] Hide UI elements related to IdleDetection Sep 28, 2021
@kjozwiak kjozwiak added privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. release-notes/exclude labels Oct 5, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2021

Looks like this working as expected on Android. Went through the following verification/checks using the following build:

Nightly 1.32.44 Chromium: 94.0.4606.71

Case #1 - IdleDetection disabled

  • checked https://idle-detection.glitch.me and ensured that the Idle Detection API is disabled
  • verified that there's no UI associated with Idle Detection visible under Settings -> Site Settings
  • verified that there's no UI associated with Idle Detection visible under Settings -> Site Settings -> All Sites
Example Example Example Example
Screenshot_20211005-200656_Brave - Nightly Screenshot_20211005-200707_Brave - Nightly Screenshot_20211005-200711_Brave - Nightly Screenshot_20211005-200729_Brave - Nightly

Case #2 - IdleDetection enabled

  • launched Brave using --enable-features=IdleDetection
  • ensured that visiting https://idle-detection.glitch.me allows you to enable the Idle Detection API
  • ensured that enabling the Idle Detection API displays a permission modal
  • ensured that Your device use appears under All Sites under Site Settings for https://idle-detection.glitch.me
  • ensured disabling Idle Detection by removing --enable-features=IdleDetection removes the UI from All Sites
Example Example
Screenshot_20211005-170102_Brave - Nightly Screenshot_20211005-170157_Brave - Nightly

Closing this of after speaking with @mkarolin & @SergeyZhukovsky. We'll also QA the above on Android via #18409.

@kjozwiak kjozwiak closed this as completed Oct 6, 2021
@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed release-notes/exclude labels Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium.
Projects
None yet
Development

No branches or pull requests

2 participants