build: Update cargo deny configs to v0.6.2 #686
Conversation
|
@jahkeup CI failure seems to be due to cargo-deny 0.2.6 being installed, do we have to deploy a new build container for this? |
|
@iliana yep, we'll need the crates listing updated and then rebuild + push for the CI environment to pick up the change. |
|
It's updated in this PR, do we want to kick off a build before we merge this? |
|
Nice, thanks for updating that! (I missed it when I read through quickly on my phone!) Let's get the container image built with these changes and passing with this change before we merge - otherwise the other PRs will start failing. |
|
Rebased to drop the systemd crate from the license exceptions. |
| ignore = [ | ||
| # crossbeam-queue: | ||
| # - Bounded MPMC queue: BSD-2-Clause-FreeBSD | ||
| { name = "crossbeam-queue", license_files = [{ path = "LICENSE-THIRD-PARTY", hash = 0x7e40bc60 }] }, |
There was a problem hiding this comment.
Pointing to crossbeam here as an example of one of the "ignore" lines that disappeared across the couple files. You said you had a suspicion that it's checking the Cargo.toml metadata now rather than (or in preference to) licensing files. We should confirm whether that's true, and whether it's OK to go by the metadata in the case of a conflict. If so, and if all of these removals are understood to be that case (or something uncontroversial) then I think we're OK.
Issue #, if available: Closes #531
Description of changes:
Moving to the most recent cargo-deny, which simplifies these configs significantly. :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.