Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deny.toml to cargo-deny v0.4 #531

Closed
iliana opened this issue Nov 18, 2019 · 4 comments · Fixed by #686
Closed

Update deny.toml to cargo-deny v0.4 #531

iliana opened this issue Nov 18, 2019 · 4 comments · Fixed by #686

Comments

@iliana
Copy link
Contributor

iliana commented Nov 18, 2019

#495 (comment)

v0.4.0 renamed Openssl to OpenSSL and may have made some changes involving license exceptions.

@jahkeup
Copy link
Member

jahkeup commented Nov 18, 2019

This highlights the need for a defined and consistent build/development environment for folks. I did a quick look around for a way to write down binary-crate dependencies in Cargo.toml and came up empty handed.

We should have an environment compatibility check or maybe at a minimum a dependency listing of "known working" versions for ourselves and other contributors.

@iliana
Copy link
Contributor Author

iliana commented Nov 18, 2019

Yeah, I would appreciate being able to lock what binaries are used to build in Cargo.lock. I don't think there's a reasonable way to do that quite yet but I'll see if I can try to find a workaround.

@iliana
Copy link
Contributor Author

iliana commented Dec 10, 2019

EmbarkStudios/cargo-deny#50
EmbarkStudios/cargo-deny#51
EmbarkStudios/cargo-deny#53

WIP branch: wip-cargo-deny-v0.4

@iliana
Copy link
Contributor Author

iliana commented Jan 7, 2020

v0.5.2 has all the documented issues we've had fixed, so it's perhaps time to pick this up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants