-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kubernetes 1.21 variants #2700
Remove kubernetes 1.21 variants #2700
Conversation
Should be ready to review, but marking as draft as we don't want to merge this until we are ready for the next release after the February EOL date. |
9e74e2a
to
2016c31
Compare
2016c31
to
bb919a4
Compare
Rebased on the latest from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - noticed this odd referenced to a 1.21 k8s variant in some test:
Test {
input: "aws-k8s-1.21",
platform: "aws",
runtime: "k8s",
variant_family: "aws-k8s",
variant_version: Some("1.21"),
variant_flavor: None,
},
worth also updating that?
I almost did that, but decided I didn't want to set the precedent that we need to remember to bump this every time we raise the minimum k8s version. Since in this case it is just used as test input and has no actual meaning, it may actually be better to have this refer to a variant that doesn't currently exist to help make it clear that it is just dummy test data. |
Switching back over to draft status until everyone is comfortable that we actually can drop 1.21. |
This removes the 1.21 k8s variants. This version of Kubernetes has gone end of life and we will no longer support it. Docs and other references to 1.21 have been updated to refer to more current versions. Signed-off-by: Sean McGinnis <[email protected]>
bb919a4
to
da5293e
Compare
Issue number:
Closes #2633
Description of changes:
This removes the 1.21 k8s variants. This version of Kubernetes has gone end of life and we will no longer support it.
Docs and other references to 1.21 have been updated to refer to more current versions.
Note to reviewers
See #2421 and #2316 for examples of past removals of k8s version variants.
Testing done:
cargo make -e BUILDSYS_VARIANT=aws-k8s-1.22 -e BUILDSYS_ARCH=x86_64
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.