Remove kubernetes 1.20 variants #2421
Merged
+24
−780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this draft until we're abit closer to the November timeline (when EKS support for k8s 1.20 will drop per the issue noted above) |
jpmcb
force-pushed
the
deprecate-k8s-1.20
branch
from
3c142b2
to
d7c1ff5
Compare
|
Ready for review now and will target the |
etungsten
suggested changes
Oct 18, 2022
There was a problem hiding this comment.
We should delete models/src/aws-k8s-1.20 like in https://github.com/bottlerocket-os/bottlerocket/pull/2316/files#.
jpmcb
force-pushed
the
deprecate-k8s-1.20
branch
from
d7c1ff5
to
72da26d
Compare
|
Force pushed to also remove |
etungsten
approved these changes
Oct 19, 2022
bcressey
approved these changes
Oct 19, 2022
- Remove aws-k8s-1.20 variant - Remove vmware-k8s-1.20 variant Signed-off-by: John McBride <[email protected]>
jpmcb
force-pushed
the
deprecate-k8s-1.20
branch
from
72da26d
to
e83f600
Compare
|
Force pushed to address Ben's comment: Added |
bcressey
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2400
Reference PR: #2316
Description of changes:
Testing done:
cargo make check && cargo make build👍🏼Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.