-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS Organizations to Pubsys #2484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
approved these changes
Oct 7, 2022
jpculp
approved these changes
Oct 7, 2022
zmrow
reviewed
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide an example of what this cargo make
call looks like in the Testing Done
section?
webern
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Updated Pubsys grant image to be able to modify images attributes to add permissions for AWS Organizations and Organizational Units. EBS Snapshots do not currently support organizations so they have not been changed.
rpkelly
force-pushed
the
pubsys-groups
branch
from
November 7, 2022 18:53
dac7679
to
f2c62d4
Compare
jpculp
reviewed
Nov 8, 2022
webern
approved these changes
Nov 8, 2022
zmrow
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #1960
Description of changes:
Updated Pubsys grant image to be able to modify images attributes to add permissions for AWS Organizations and Organizational Units.
EBS Snapshots do not currently support organizations so they have not been changed.
Testing done:
Added and revoked organization in my account
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.