Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS Organizations to Pubsys #2484

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

rpkelly
Copy link
Contributor

@rpkelly rpkelly commented Oct 7, 2022

Issue number:

Closes #1960

Description of changes:
Updated Pubsys grant image to be able to modify images attributes to add permissions for AWS Organizations and Organizational Units.

EBS Snapshots do not currently support organizations so they have not been changed.

Testing done:
Added and revoked organization in my account

cargo make -e PUBLISH_INFA_CONFIG_PATH=~/Infra.toml -e GRANT_TO_ORGS=arn:aws:organizations::xxxxxxxxxxxx:organization/o-xxxxxxxxxx -e PUBLISH_REGIONS=us-west-2 grant-ami
cargo make -e PUBLISH_INFA_CONFIG_PATH=~/Infra.toml -e REVOKE_FROM_ORGS=arn:aws:organizations::xxxxxxxxxxxx:organization/o-xxxxxxxxxx -e PUBLISH_REGIONS=us-west-2 revoke-ami

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpculp jpculp removed their assignment Oct 7, 2022
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide an example of what this cargo make call looks like in the Testing Done section?

tools/pubsys/src/aws/publish_ami/mod.rs Show resolved Hide resolved
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Makefile.toml Outdated Show resolved Hide resolved
tools/pubsys/src/aws/publish_ami/mod.rs Show resolved Hide resolved
Updated Pubsys grant image to be able to modify images attributes to
add permissions for AWS Organizations and Organizational Units.

EBS Snapshots do not currently support organizations so they have not
been changed.
@rpkelly rpkelly merged commit 28a4460 into bottlerocket-os:develop Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grant AMI to organization and/or organization units
5 participants