Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant AMI to organization and/or organization units #1960

Closed
samjo-nyang opened this issue Feb 16, 2022 · 2 comments · Fixed by #2484
Closed

Grant AMI to organization and/or organization units #1960

samjo-nyang opened this issue Feb 16, 2022 · 2 comments · Fixed by #2484
Assignees
Labels
type/enhancement New feature or request
Milestone

Comments

@samjo-nyang
Copy link
Contributor

What I'd like:
I'd like to share AMIs with organizations and/or organization units.

It would be nice if it supports the following (or similar) commands:

cargo make -e GRANT_TO_ORG_ARNS=arn:aws:organizations::123456789012:organization/o-123example grant-ami

I think that changing this file will work, but I didn't test it.

Any alternatives you've considered:

@etungsten etungsten added priority/p1 type/enhancement New feature or request status/needs-triage Pending triage or re-evaluation labels Feb 18, 2022
@kdaula kdaula removed the status/needs-triage Pending triage or re-evaluation label Feb 21, 2022
@kdaula kdaula added this to v1.8.0 Feb 21, 2022
@webern
Copy link
Contributor

webern commented Feb 22, 2022

Here we can see the API that you are referring to: https://docs.aws.amazon.com/cli/latest/reference/ec2/modify-image-attribute.html

[--organization-arns <value>]
[--organizational-unit-arns <value>]

However, we are using Rusoto and I'm not seeing organizations in the ModifyImageAttributesRequest. https://rusoto.github.io/rusoto/rusoto_ec2/struct.ModifyImageAttributeRequest.html

If we look at the new Rust SDK, we do see the necessary fields available. https://docs.rs/aws-sdk-ec2/0.6.0/aws_sdk_ec2/input/struct.ModifyImageAttributeInput.html

So, unfortunately, if I'm reading these sources correctly, it looks like we may need to switch from rusoto to the AWS SDK to do this.

@kdaula kdaula removed this from v1.8.0 Mar 7, 2022
@kdaula kdaula added this to v1.8.0 Mar 7, 2022
@kdaula kdaula removed this from v1.8.0 Mar 7, 2022
@kdaula kdaula added this to the Q3 milestone Mar 7, 2022
@kdaula kdaula modified the milestones: Q3, 1.10.0 Jun 1, 2022
@rpkelly rpkelly self-assigned this Aug 9, 2022
@arnaldo2792
Copy link
Contributor

Hi @samjo-nyang!, I think we will punt this to the following release (1.11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

6 participants