Remove redundant closure #2346
Merged
Remove redundant closure #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
force-pushed
the
redundant-closure
branch
from
8185e78
to
b8faf14
Compare
etungsten
previously approved these changes
Aug 15, 2022
etungsten
reviewed
Aug 15, 2022
Clippy warnings about a redundant closure. The closure just makes a call to a function that would take the passed argument anyway, so we should remove the closure and just provide the function directly. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
redundant-closure
branch
from
b8faf14
to
5865114
Compare
ecpullen
approved these changes
Aug 15, 2022
etungsten
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2345
Description of changes:
Clippy warnings about a redundant closure. The closure just makes a call
to a function that would take the passed argument anyway, so we should
remove the closure and just provide the function directly.
Testing done:
Built with changes and verified rust was happy.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.