Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase vm.max_map_count to match AL2 setting #2344

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

stmcginnis
Copy link
Contributor

@stmcginnis stmcginnis commented Aug 15, 2022

Issue number:

Related #1525

Description of changes:

This increases the vm.max_map_count to match the value configured in
Amazon Linux so we have a consistent value and user experience across AL
and Bottlerocket.

Related AL change: awslabs/amazon-eks-ami#589

Testing done:

Verified value changed in deployed image.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@stmcginnis
Copy link
Contributor Author

Related discussion: #2335 (review)

cc @markusboehme

@markusboehme
Copy link
Member

I'm afraid this needs a rebase to pick up #2346 and unblock the build.

@markusboehme
Copy link
Member

@stmcginnis Looks like the latest push brought along an alpinetest.yaml file by accident.

This increases the vm.max_map_count to match the value configured in
Amazon Linux so we have a consistent value and user experience across AL
and Bottlerocket.

Signed-off-by: Sean McGinnis <[email protected]>
@stmcginnis
Copy link
Contributor Author

Looks like the latest push brought along an alpinetest.yaml file by accident.

Oops, thanks for catching that!

@stmcginnis stmcginnis merged commit e20ff6c into bottlerocket-os:develop Aug 17, 2022
@stmcginnis stmcginnis deleted the max_map_count branch August 17, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants