kernel: config: clean up '=n' settings #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling a kernel config setting is usually done in a config file in
the form of
\# CONFIG_<CONFIG_NAME> is not set
instead of
CONFIG_<CONFIG_NAME>=n
While both today should be equivalent historically there was problems
with specifying '=n' still making that setting defined and having the
opposite effect of what is intended by setting '=n'. Nowadays either way
will result in a final config that will only have the `is not set`
variant for all deactivated options, so the diff of the resulting
artifact before and after this patch will be empty.
As the `is not used` form is the commonly used form, lets adhere to it.
As a bonus it reduces the noise when comparing configs that are manually
merged using the merge-config script.
Replaced all the '=n' settings by the common form through command:
for file in packages/kernel*/config*;
do
sed -E -i "s/^(CONFIG_[A-Z0-9_]*)=n/# \1 is not set/g" $file;
done
Signed-off-by: Leonard Foerster <[email protected]>
markusboehme
approved these changes
Jul 22, 2022
jpculp
approved these changes
Jul 22, 2022
bcressey
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2289
Description of changes:
Clean up an un-common way of disabling kernel config options. See commit message above for more detail.
Testing done:
Checked resulting config that will be installed as part of the kernel rpm before and after this patch. The diff is empty.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.