Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel config: tidy up config fragments #2289

Open
1 of 2 tasks
foersleo opened this issue Jul 21, 2022 · 2 comments
Open
1 of 2 tasks

kernel config: tidy up config fragments #2289

foersleo opened this issue Jul 21, 2022 · 2 comments
Assignees
@foersleo
Labels
area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request

Comments

@foersleo
Copy link
Contributor

foersleo commented Jul 21, 2022 •
edited
Loading

There is some things to tidy up for the parts we set for our kernel configs:

  • Usage of CONFIG_FOO=n instead of # CONFIG_FOO is not set to deactivate a setting
  • Check if there is any conflicts that merge-config brings up (e.g. intended to have something build in, but dependency options are build as module; merge-config will complain about those)
@foersleo foersleo self-assigned this Jul 21, 2022
@foersleo foersleo mentioned this issue Jul 21, 2022
Merged
@foersleo foersleo mentioned this issue Aug 24, 2022
Closed
@foersleo
Copy link
Contributor Author

foersleo commented Nov 4, 2022 •
edited
Loading

There is some differences in the 5.10 kernel between the configs for x86_64 and aarch64 configurations we include from our upstream.

  • aarch64 includes a bunch of IR drivers we do not need that are not in x86_64, see chain RC_CORE -> RC_DECODERS -> IR_*_DECODER
  • aarch64 has some USB host controller drivers built-in vs. built as module for x86_64, see USB_*HCI*

@stmcginnis stmcginnis added the status/needs-triage Pending triage or re-evaluation label Dec 1, 2022
@stmcginnis stmcginnis added type/enhancement New feature or request area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized and removed status/needs-triage Pending triage or re-evaluation labels Mar 13, 2023
@foersleo foersleo mentioned this issue Jun 29, 2023
Merged
2 tasks
@markusboehme
Copy link
Member

  • ixgbe driver is only needed for metal variants
  • smartpqi driver is only needed for metal variants
  • become more consistent with selection of EDAC drivers, e.g. we disable EDAC_I10NM but have drivers for other Intel micro-archs enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foersleo foersleo

Labels
area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request
Projects
Bottlerocket Engineering Roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stmcginnis @markusboehme @foersleo