Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NVIDIA docker configurations #2097

Merged

Conversation

arnaldo2792
Copy link
Contributor

@arnaldo2792 arnaldo2792 commented Apr 23, 2022

Issue number:
Closes #2087

Description of changes:

This adds the shimpei and docker configurations to set up the `nvidia`
runtime for variants that use docker as their containers runtime.

Testing done:

  • In aws-k8s-1.21-nvidia, I confirmed that the shimpei configurations were created for the nvidia runtime
  • In a local build of a new ECS variant that uses the new nvidia-oci-hooks-docker.toml and docker-daemon-nvidia.toml, I confirmed that shimpei configurations were created for both the default and nvidia runtimes, and that the docker configuration included both runtimes as in daemon-nvidia-json:
# Shimpei configurations
bash-5.1# ls /etc/shimpei/
nvidia-oci-hooks.json  shimpei-hooks.json
# Docker configuration with both runtimes
[root@admin]# cat /.bottlerocket/rootfs/etc/docker/daemon.json
{
  "log-driver": "journald",
  "live-restore": true,
  "max-concurrent-downloads": 10,
  "storage-driver": "overlay2",
  "exec-opts": ["native.cgroupdriver=cgroupfs"],
  "data-root": "/var/lib/docker",
  "default-runtime": "nvidia",
  "runtimes": { "shimpei": { "path": "shimpei" }, "nvidia": { "path": "nvidia-oci" } },
  "selinux-enabled": true,
  "default-ulimits": { "nofile": { "Name": "nofile", "Soft": 1024, "Hard": 4096 } }
}

Reviewers can see the local variant in this branch, I used that branch to test an ECS task that uses GPUs.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@bcressey
Copy link
Contributor

nit: NVDIA typo in commit

@arnaldo2792 arnaldo2792 changed the title Add NVDIA docker configurations Add NVIDIA docker configurations Apr 27, 2022
This adds the shimpei and docker configurations to set up the `nvidia`
runtime for variants that use docker as their containers runtime.

Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
@arnaldo2792
Copy link
Contributor Author

(Forced push fixes commit message typo)

@arnaldo2792 arnaldo2792 merged commit c417a70 into bottlerocket-os:develop Apr 27, 2022
@arnaldo2792 arnaldo2792 deleted the nvidia-docker-configurations branch June 21, 2022 02:05
@bcressey bcressey mentioned this pull request Jun 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ECS] Add docker and shimpei templated configuration for the NVIDIA runtime
3 participants