Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2087
Description of changes:
Testing done:
shimpei
configurations were created for thenvidia
runtimenvidia-oci-hooks-docker.toml
anddocker-daemon-nvidia.toml
, I confirmed thatshimpei
configurations were created for both the default andnvidia
runtimes, and that thedocker
configuration included both runtimes as indaemon-nvidia-json
:# Shimpei configurations bash-5.1# ls /etc/shimpei/ nvidia-oci-hooks.json shimpei-hooks.json
Reviewers can see the local variant in this branch, I used that branch to test an ECS task that uses GPUs.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.