Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modules compression #1689

Merged

Conversation

arnaldo2792
Copy link
Contributor

Issue number:
N / A

Description of changes:

d8df7a97 packages: remove kernel modules compression for 5.10 kernel
df524248 packages: remove kernel module compression for 5.4 kernel

In #1668, we started to compress the kernel modules using the Zstandard, but we found two problems with that:

  • Some times the kernel modules' build will hang while compressing them
  • kube-proxy loads some kernel modules from /lib/modules (which are compressed), with an old version of kmod that doesn't support zstd compression

This PR includes the commits to remove the configurations to compress the kernel modules with the Zstandard, in both the 5.4 and 5.10 kernels.

Testing done:
In aws-k8s-1.19, aws-k8s-1.21

  • I waited for 1 hour and check that journalctl -p notice didn't show the errors related to failed kernel module loads
  • Pods are still running
  • Build doesn't hang
# in 1.21
bash-5.0# apiclient -u /os
{"pretty_name":"Bottlerocket OS 1.1.4","variant_id":"aws-k8s-1.21","version_id":"1.1.4","build_id":"1d0328c7-dirty","arch":"x86_64"}
bash-5.0# journalctl -p notice | grep modprobe

# in 1.19
bash-5.0# apiclient -u  /os
{"pretty_name":"Bottlerocket OS 1.1.4","variant_id":"aws-k8s-1.19","version_id":"1.1.4","build_id":"1d0328c7-dirty","arch":"x86_64"}
bash-5.0# journalctl -p notice | grep ELF

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@arnaldo2792 arnaldo2792 merged commit 4c82044 into bottlerocket-os:develop Aug 3, 2021
@tjkirch tjkirch mentioned this pull request Aug 3, 2021
@arnaldo2792 arnaldo2792 deleted the remove-modules-compression branch November 29, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants